Fix CodeQL security issues (#7985)

This path fixes 7 issues raised by codeql:

- `dxcapi.use.h` - [SM01925] Uncontrolled process operation: Add
comment, so the scan can ignore this issue.
- `ProgramTest.cpp` - [SM01932] User-controlled data may not be null
terminated: Add comment, so the scan can ignore this issue.
- `DxbcConverter.cpp` - [SM01928] Comparison of narrow type with wide
type in loop condition: Change affected variable to be `unsigned`
instead of `BYTE`.
- `ExecutionTest.cpp` - [SM01733] Too few arguments to formatting
function: Remove an argument that didn't seem to be used.
- `DxbcUtil.cpp` - [SM01928] Comparison of narrow type with wide type in
loop condition: Cast the result of `+` operator back to BYTE, since it
was implicit being cast to an int.
- `DSAclean.py` - [SM03905] Inefficient regular expression: Script
doesn't seem to be used anymore, so it is being removed.
- `CaptureCmd` - [SM02167] Weak hashes : Script doesn't seem to be used
anymore, so it is being removed.

---------

Co-authored-by: Joao Saffran <[email protected]>

Author: joaosaffran

include/dxc/Support/dxcapi.use.h

@@ -69,7 +69,9 @@ class SpecificDllLoader : public DllLoader {
       return S_OK;
 
 #ifdef _WIN32
-    m_dll = LoadLibraryA(dllName);
+    m_dll = LoadLibraryA(
+        dllName); // CodeQL [SM01925] This is by design, intended to be used to
+                  // test multiple validators versions.
     if (m_dll == nullptr)
       return HRESULT_FROM_WIN32(GetLastError());
     m_createFn = (DxcCreateInstanceProc)GetProcAddress(m_dll, fnName);
@@ -81,7 +83,9 @@ class SpecificDllLoader : public DllLoader {
       return hr;
     }
 #else
-    m_dll = ::dlopen(dllName, RTLD_LAZY);
+    m_dll = ::dlopen(
+        dllName, RTLD_LAZY); // CodeQL [SM01925] This is by design, intended to
+                             // be used to test multiple validators versions.
     if (m_dll == nullptr)
       return E_FAIL;
     m_createFn = (DxcCreateInstanceProc)::dlsym(m_dll, fnName);

projects/dxilconv/lib/DxbcConverter/DxbcConverter.cpp

@@ -6393,8 +6393,8 @@ void DxbcConverter::EmitGSOutputRegisterStore(unsigned StreamId) {
     CompType DxbcValueType = SE.GetCompType();
     Type *pDxbcValueType = DxbcValueType.GetLLVMType(m_Ctx);
 
-    for (BYTE c = 0; c < SE.GetCols(); c++) {
-      BYTE Comp = SE.GetStartCol() + c;
+    for (unsigned c = 0; c < SE.GetCols(); c++) {
+      unsigned Comp = SE.GetStartCol() + c;
 
       Value *pValue;
       // 1. Load value from the corresponding temp reg.

projects/dxilconv/lib/DxbcConverter/DxbcUtil.cpp

@@ -17,6 +17,7 @@
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/IR/Type.h"
 #include "llvm/Support/Casting.h"
+#include <cassert>
 
 #include "DxbcUtil.h"
 #include "Support/DXIncludes.h"
@@ -46,7 +47,8 @@ CMask::CMask(BYTE StartComp, BYTE NumComp) {
                (StartComp + NumComp - 1) < DXBC::kAllCompMask,
            "otherwise the caller did not check");
   m_Mask = 0;
-  for (BYTE c = StartComp; c < StartComp + NumComp; c++) {
+  BYTE EndComp = StartComp + NumComp;
+  for (BYTE c = StartComp; c < EndComp; c++) {
     m_Mask |= (1 << c);
   }
 }

tools/clang/unittests/HLSLExec/ExecutionTest.cpp

@@ -2451,7 +2451,7 @@ TEST_F(ExecutionTest, WaveIntrinsicsTest) {
     }
 
     // Waves should cover 4 threads or more.
-    LogCommentFmt(L"Found %u distinct lane ids: %u", firstLaneIds.size());
+    LogCommentFmt(L"Found %u distinct lane ids", firstLaneIds.size());
     if (!dxbc) {
       VERIFY_IS_GREATER_THAN_OR_EQUAL(values.size() / 4, firstLaneIds.size());
     }

tools/clang/utils/CaptureCmd

@@ -313,7 +313,8 @@ TEST(ProgramTest, TestWriteWithSystemEncoding) {
 #else
   char buf[10];
   ASSERT_EQ(::read(fd, buf, 10), 10);
-  ASSERT_EQ(strncmp(buf, utf8_text, 10), 0);
+  ASSERT_EQ(strncmp(buf, utf8_text, 10),
+            0); // CodeQL [SM01932] the file content is controlled by the test.
 #endif
   ::close(fd);
   ASSERT_NO_ERROR(fs::remove(file_pathname.str()));