Skip to content

Consider changing log severity of double dispose so not critical #394

@quails4Eva

Description

@quails4Eva

I think to make the library closer to a drop in replacement to MemoryStream it would be good if double dispose wasn't logged as a critical, maybe information instead.

I understand the rationale for logging it and agree that it's useful, but given that double dispose is explicitly called out as being fine in the Stream docs, Asp.Net Core double disposes returned streams, and there's no negative impact in practice, I think critical seems like an overly severe categorisation.

See also dotnet/aspnetcore#59514

I can manually filter/modify the logs for my app, but seems like something to consider changing in the library?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions