Skip to content

Commit e80f0d1

Browse files
authored
Merge pull request #518 from microsoft/main
1.70
2 parents 648a786 + bcb11b3 commit e80f0d1

File tree

6 files changed

+20
-12
lines changed

6 files changed

+20
-12
lines changed

_implementors/adapters.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ Many adapters publish releases tailored for specific editors, such as VS Code, a
5656
[LLDB Debugger](https://github.com/vadimcn/vscode-lldb)|[@vadimcn](https://github.com/vadimcn)|[VS Code](https://marketplace.visualstudio.com/items?itemName=vadimcn.vscode-lldb)
5757
[Lua and Ravi 5.3 Debugger](https://github.com/dibyendumajumdar/ravi-vscode-debugger)|[@dibyendumajumdar](https://github.com/dibyendumajumdar)|[VS Code](https://marketplace.visualstudio.com/items?itemName=ravilang.ravi-debug)
5858
[Lua Debug](https://github.com/actboy168/lua-debug)|[@actboy168](https://github.com/actboy168)|[VS Code](https://marketplace.visualstudio.com/items?itemName=actboy168.lua-debug)
59+
[Luau Debugger](https://github.com/sssooonnnggg/luau-debugger)|[@sssooonnnggg](https://github.com/sssooonnnggg)|[VS Code](https://marketplace.visualstudio.com/items?itemName=sssooonnnggg.luau-debugger)
5960
[Mock Debug](https://github.com/Microsoft/vscode-mock-debug)|[@roblourens](https://github.com/roblourens)|[VS Code](https://marketplace.visualstudio.com/items?itemName=ms-vscode.mock-debug)
6061
[Mono Debug](https://github.com/Microsoft/vscode-mono-debug)|[@akoeplinger](https://github.com/akoeplinger)|[VS Code](https://marketplace.visualstudio.com/items?itemName=ms-vscode.mono-debug)
6162
[NAME](https://github.com/utdscheld/name)|[John Cole](https://personal.utdallas.edu/~John.Cole/)|

changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ sectionid: changelog
66

77
#### All notable changes to the specification will be documented in this file.
88

9+
* 1.70.x
10+
* Clarify how `StackTraceArguments.format` applies
11+
* Clarify the default behavior of `ContinuedEvent.allThreadsContinued`
12+
913
* 1.69.x
1014
* Clarify the flow diagram to start a debug session
1115
* Add `supportsANSIStyling` capabilities to allow colorization of text from debug adapters

debugAdapterProtocol.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@
249249
},
250250
"allThreadsContinued": {
251251
"type": "boolean",
252-
"description": "If `allThreadsContinued` is true, a debug adapter can announce that all threads have continued."
252+
"description": "If omitted or set to `true`, this event signals to the client that all threads have been resumed. The value `false` indicates that not all threads were resumed."
253253
}
254254
},
255255
"required": [ "threadId" ]
@@ -1673,7 +1673,7 @@
16731673
"properties": {
16741674
"allThreadsContinued": {
16751675
"type": "boolean",
1676-
"description": "The value true (or a missing property) signals to the client that all threads have been resumed. The value false indicates that not all threads were resumed."
1676+
"description": "If omitted or set to `true`, this response signals to the client that all threads have been resumed. The value `false` indicates that not all threads were resumed."
16771677
}
16781678
}
16791679
}
@@ -2033,7 +2033,7 @@
20332033
},
20342034
"format": {
20352035
"$ref": "#/definitions/StackFrameFormat",
2036-
"description": "Specifies details on how to format the stack frames.\nThe attribute is only honored by a debug adapter if the corresponding capability `supportsValueFormattingOptions` is true."
2036+
"description": "Specifies details on how to format the returned `StackFrame.name`. The debug adapter may format requested details in any way that would make sense to a developer.\nThe attribute is only honored by a debug adapter if the corresponding capability `supportsValueFormattingOptions` is true."
20372037
}
20382038
},
20392039
"required": [ "threadId" ]

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ <h1 class="text-center"><i class="fa fa-cogs" aria-hidden="true"></i></h1>
8686
<h1 class="text-center"><i class="fas fa-book" aria-hidden="true"></i></h1>
8787
<a href='{{ "/specification" | prepend: site.baseurl }}'><h3 class="text-center">Specification</h3></a>
8888
<p>
89-
The latest version of the protocol specification is version 1.64.0.
89+
The latest version of the protocol specification is version 1.70.0.
9090
</p>
9191
<p>
9292
<a href='{{ "/changelog" | prepend: site.baseurl }}'>Change History</a>

overview.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ After the response to `configurationDone` is sent, the debug adapter may respond
179179

180180
The following sequence diagram summarizes the sequence of requests and events for a hypothetical _gdb_ debug adapter:
181181

182-
<img src="./img/init-launch.svg" width="100%">
182+
<img src="./img/init-launch.svg" width="100%" alt="Sequence diagram of the launch flow">
183183

184184
### Stopping and accessing debuggee state
185185

@@ -233,7 +233,7 @@ If the debuggee has ended (and the debug adapter is able to detect this), an opt
233233

234234
This diagram summarizes the sequence of request and events for a hypothetical debug adapter for _gdb_:
235235

236-
<img src="./img/stop-continue-terminate.svg" width="100%" />
236+
<img src="./img/stop-continue-terminate.svg" width="100%" alt="Sequence diagram of the termination flow" />
237237

238238
## Libraries (SDKs) for DAP providers and consumers
239239

specification.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,9 @@ interface ContinuedEvent extends Event {
313313
threadId: number;
314314

315315
/**
316-
* If `allThreadsContinued` is true, a debug adapter can announce that all
317-
* threads have continued.
316+
* If omitted or set to `true`, this event signals to the client that all
317+
* threads have been resumed. The value `false` indicates that not all
318+
* threads were resumed.
318319
*/
319320
allThreadsContinued?: boolean;
320321
};
@@ -1811,9 +1812,9 @@ Response to `continue` request.
18111812
interface ContinueResponse extends Response {
18121813
body: {
18131814
/**
1814-
* The value true (or a missing property) signals to the client that all
1815-
* threads have been resumed. The value false indicates that not all threads
1816-
* were resumed.
1815+
* If omitted or set to `true`, this response signals to the client that all
1816+
* threads have been resumed. The value `false` indicates that not all
1817+
* threads were resumed.
18171818
*/
18181819
allThreadsContinued?: boolean;
18191820
};
@@ -2222,7 +2223,9 @@ interface StackTraceArguments {
22222223
levels?: number;
22232224

22242225
/**
2225-
* Specifies details on how to format the stack frames.
2226+
* Specifies details on how to format the returned `StackFrame.name`. The
2227+
* debug adapter may format requested details in any way that would make sense
2228+
* to a developer.
22262229
* The attribute is only honored by a debug adapter if the corresponding
22272230
* capability `supportsValueFormattingOptions` is true.
22282231
*/

0 commit comments

Comments
 (0)