Skip to content

Commit 266e9d6

Browse files
badrishcbadrishc
authored
Fix unit tests to work on VS2026. Minor changes. (#1410)
1 parent 3682b3f commit 266e9d6

File tree

4 files changed

+16
-15
lines changed

4 files changed

+16
-15
lines changed

‎test/Garnet.test/RespEtagTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1330,7 +1330,7 @@ public void SimpleIncrementByFloatForEtagSetData(double initialValue, double inc
13301330
var actualResultRawStr = db.StringGet(key);
13311331

13321332
var actualResult = double.Parse(actualResultStr, CultureInfo.InvariantCulture);
1333-
var actualResultRaw = double.Parse(actualResultRawStr, CultureInfo.InvariantCulture);
1333+
var actualResultRaw = double.Parse((string)actualResultRawStr, CultureInfo.InvariantCulture);
13341334

13351335
Assert.That(actualResult, Is.EqualTo(expectedResult).Within(1.0 / Math.Pow(10, 15)));
13361336
Assert.That(actualResult, Is.EqualTo(actualResultRaw).Within(1.0 / Math.Pow(10, 15)));

‎test/Garnet.test/RespListTests.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1322,7 +1322,8 @@ public void CanDoBasicLMPOP()
13221322

13231323
result = db.ListRightPop([new RedisKey("test"), key2], 2);
13241324
ClassicAssert.AreEqual(key2, result.Key);
1325-
ClassicAssert.AreEqual(key2Values.Reverse(), result.Values);
1325+
key2Values.Reverse();
1326+
ClassicAssert.AreEqual(key2Values, result.Values);
13261327
}
13271328

13281329
[Test]

‎test/Garnet.test/RespScanCommandsTests.cs‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ public void CanUseScanWithEmptyStore()
301301
var db = redis.GetDatabase(0);
302302
var result = db.Execute("SCAN", "0");
303303
ClassicAssert.AreEqual(ResultType.BulkString, result[0].Resp2Type);
304-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out var cursor);
304+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out var cursor);
305305
RedisValue[] keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
306306
ClassicAssert.IsTrue(cursor == 0);
307307
ClassicAssert.IsTrue(keysMatch.Length == 0);
@@ -339,7 +339,7 @@ public void CanUseScanAllKeys()
339339
{
340340
var result = db.Execute("SCAN", cursor.ToString());
341341
ClassicAssert.AreEqual(ResultType.BulkString, result[0].Resp2Type);
342-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
342+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
343343
RedisValue[] keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
344344
recordsReturned += keysMatch.Length;
345345
} while (cursor != 0);
@@ -367,7 +367,7 @@ public void CanUseScanKeysWithCount()
367367
do
368368
{
369369
var result = db.Execute("SCAN", cursor.ToString(), "COUNT", count);
370-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
370+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
371371
RedisValue[] keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
372372
recordsReturned += keysMatch.Length;
373373
count = rnd.Next(1, 20);
@@ -390,7 +390,7 @@ public void CanUseScanKeysWithMatchAndCount()
390390

391391
int cursor = 0;
392392
var result = db.Execute("SCAN", cursor.ToString(), "MATCH", "*11*", "COUNT", 1000);
393-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
393+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
394394
RedisValue[] keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
395395
ClassicAssert.IsTrue(cursor == 0);
396396
ClassicAssert.IsTrue(keysMatch.Length == 11);
@@ -410,7 +410,7 @@ public void CanUseScanKeysCountAndStringType()
410410

411411
int cursor = 0;
412412
var result = db.Execute("SCAN", cursor.ToString(), "TYPE", "string", "COUNT", "100");
413-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
413+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
414414
RedisValue[] keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
415415
ClassicAssert.IsTrue(cursor == 0);
416416
ClassicAssert.IsTrue(keysMatch.Length == 100);
@@ -445,22 +445,22 @@ public void CanUseScanKeysCountAndTypeWithObjects()
445445

446446
int cursor = 0;
447447
var result = db.Execute("SCAN", cursor.ToString(), "TYPE", "string", "COUNT", "100");
448-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
448+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
449449
RedisValue[] keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
450450
ClassicAssert.IsTrue(cursor == 0);
451451
ClassicAssert.IsTrue(keysMatch.Length == 100);
452452

453453
cursor = 0;
454454
result = db.Execute("SCAN", cursor.ToString(), "TYPE", "zset");
455-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
455+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
456456
keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
457457
ClassicAssert.IsTrue(cursor == 0);
458458
ClassicAssert.IsTrue(keysMatch.Length == 10);
459459
ClassicAssert.IsTrue(keysMatch[0].ToString().Equals("sskey:0", StringComparison.OrdinalIgnoreCase));
460460

461461
cursor = 0;
462462
result = db.Execute("SCAN", cursor.ToString(), "TYPE", "LIST");
463-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
463+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
464464
keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
465465
ClassicAssert.IsTrue(cursor == 0);
466466
ClassicAssert.IsTrue(keysMatch.Length == 10);
@@ -496,7 +496,7 @@ public void CanUseScanKeysAndObjects()
496496
do
497497
{
498498
var result = db.Execute("SCAN", cursor.ToString());
499-
_ = long.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
499+
_ = long.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
500500
RedisValue[] keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
501501
recordsReturned += keysMatch.Length;
502502
} while (cursor != 0);
@@ -528,7 +528,7 @@ public void CanUseScanKeysTypeAndMatch()
528528
do
529529
{
530530
var result = db.Execute("SCAN", cursor.ToString(), "TYPE", "HASH", "MATCH", "hs*");
531-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
531+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
532532
RedisValue[] keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
533533
recordsReturned += keysMatch.Length;
534534
} while (cursor != 0);
@@ -540,7 +540,7 @@ public void CanUseScanKeysTypeAndMatch()
540540
do
541541
{
542542
var result = db.Execute("SCAN", cursor.ToString(), "type", "hash", "match", "hs*");
543-
_ = int.TryParse(((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
543+
_ = int.TryParse((string)((RedisValue[])((RedisResult[])result!)[0])[0], out cursor);
544544
RedisValue[] keysMatch = ((RedisValue[])((RedisResult[])result!)[1]);
545545
recordsReturned += keysMatch.Length;
546546
} while (cursor != 0);

‎test/Garnet.test/RespTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1360,7 +1360,7 @@ public void SimpleIncrementByFloatWithNoKey()
13601360
var actualResultRawStr = db.StringGet(key);
13611361

13621362
var actualResult = double.Parse(actualResultStr, CultureInfo.InvariantCulture);
1363-
var actualResultRaw = double.Parse(actualResultRawStr, CultureInfo.InvariantCulture);
1363+
var actualResultRaw = double.Parse((string)actualResultRawStr, CultureInfo.InvariantCulture);
13641364

13651365
Assert.That(actualResult, Is.EqualTo(expectedResult).Within(1.0 / Math.Pow(10, 15)));
13661366
Assert.That(actualResult, Is.EqualTo(actualResultRaw).Within(1.0 / Math.Pow(10, 15)));
@@ -1390,7 +1390,7 @@ public void SimpleIncrementByFloat(double initialValue, double incrByValue)
13901390
var actualResultRawStr = db.StringGet(key);
13911391

13921392
var actualResult = double.Parse(actualResultStr, CultureInfo.InvariantCulture);
1393-
var actualResultRaw = double.Parse(actualResultRawStr, CultureInfo.InvariantCulture);
1393+
var actualResultRaw = double.Parse((string)actualResultRawStr, CultureInfo.InvariantCulture);
13941394

13951395
Assert.That(actualResult, Is.EqualTo(expectedResult).Within(1.0 / Math.Pow(10, 15)));
13961396
Assert.That(actualResult, Is.EqualTo(actualResultRaw).Within(1.0 / Math.Pow(10, 15)));

0 commit comments

Comments
 (0)