Skip to content

Regarding the judgment condition for TFFTViolationLowMemoryCase #47

@PshySimon

Description

@PshySimon

I am studying how Vidur determines bottlenecks, and I noticed that both TFFTViolationLowMaxBatchSizeCase and TFFTViolationLowMemoryCase involve checking batch_size_obs. It seems that batch_size_obs should be a specific batch size value, but in TFFTViolationLowMemoryCase, it is directly compared with LOW_MEMORY_BATCH_SIZE_THRESHOLD. Could this be a mistake?

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions