Merge branch 'main' into alexr00/particular-bug

Author: alexr00

.eslintrc.base.json

@@ -55,7 +55,6 @@
 		"no-sequences": "error",
 		"no-template-curly-in-string": "warn",
 		"no-throw-literal": "error",
-		"no-unmodified-loop-condition": "warn",
 		"no-unneeded-ternary": "error",
 		"no-use-before-define": "off",
 		"no-useless-call": "error",

.eslintrc.js

@@ -0,0 +1,35 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+const RULES_DIR = require('eslint-plugin-rulesdir');
+RULES_DIR.RULES_DIR = './build/eslint-rules';
+
+module.exports = {
+	extends: ['.eslintrc.base.json'],
+	env: {
+		browser: true,
+		node: true
+	},
+	parserOptions: {
+		project: 'tsconfig.eslint.json'
+	},
+	plugins: ['rulesdir'],
+	overrides: [
+		{
+			files: ['webviews/**/*.ts', 'webviews/**/*.tsx'],
+			rules: {
+				'rulesdir/public-methods-well-defined-types': 'error'
+			}
+		},
+		{
+			files: ['**/*.ts', '**/*.tsx'],
+			rules: {
+				'rulesdir/no-any-except-union-method-signature': 'error'
+			}
+		}
+	]
+};

.eslintrc.json

@@ -11,7 +11,7 @@ about: Create a report to help us improve
 - VSCode Version:
 - OS:
 - Repository Clone Configuration (single repository/fork of an upstream repository):
-- Github Product (Github.com/Github Enterprise version x.x.x):
+- GitHub Product (GitHub.com/GitHub Enterprise version x.x.x):
 
 Steps to Reproduce:
 

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,22 @@
+## General Guidelines
+- **Follow the existing code style**: Use single quotes, semicolons, and 2-space indentation. See `.eslintrc.base.json` for detailed linting rules.
+- **TypeScript**: Use modern TypeScript features. Prefer explicit types where clarity is needed, but do not over-annotate.
+- **React/JSX**: Webviews use React-style JSX with custom factories (`vscpp`, `vscppf`).
+- **Strictness**: Some strictness is disabled in `tsconfig.base.json` (e.g., `strictNullChecks: false`), but new code should avoid unsafe patterns.
+- **Testing**: Place tests under `src/test`. Do not include test code in production files.
+- **Localization**: Use `%key%` syntax for strings that require localization. See `package.nls.json`.
+
+## Extension-Specific Practices
+- **VS Code API**: Use the official VS Code API for all extension points. Register commands, views, and menus via `package.json`.
+- **Configuration**: All user-facing settings must be declared in `package.json` under `contributes.configuration`.
+- **Activation Events**: Only add new activation events if absolutely necessary.
+- **Webviews**: Place webview code in the `webviews/` directory. Use the shared `common/` code where possible.
+- **Commands**: Register new commands in `package.json` and implement them in `src/commands.ts` or a relevant module.
+- **Logging**: Use the `Logger` utility for all logging purposes. Don't use console.log or similar methods directly.
+
+## Pull Request Guidelines
+- Never touch the yarn.lock file.
+- Run `yarn run lint` and also `npm run hygiene` and fix any errors or warnings before submitting a PR.
+
+---
+_Last updated: 2025-06-20_

.github/copilot-instructions.md

@@ -0,0 +1,68 @@
+name: "Copilot Setup Steps"
+
+# Automatically run the setup steps when they are changed to allow for easy validation, and
+# allow manual testing through the repository's "Actions" tab
+on:
+  workflow_dispatch:
+  push:
+    paths:
+      - .github/workflows/copilot-setup-steps.yml
+  pull_request:
+    paths:
+      - .github/workflows/copilot-setup-steps.yml
+
+jobs:
+  # The job MUST be called `copilot-setup-steps` or it will not be picked up by Copilot.
+  copilot-setup-steps:
+    runs-on: ubuntu-latest
+
+    # Set the permissions to the lowest permissions possible needed for your steps.
+    # Copilot will be given its own token for its operations.
+    permissions:
+      contents: read
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "yarn"
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+        env:
+          # Skip Playwright browser downloads to avoid installation failures
+          PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
+
+      - name: Install Playwright browsers (if needed)
+        run: |
+          if [ -d "node_modules/playwright" ]; then
+            echo "Installing Playwright browsers..."
+            npx playwright install --with-deps
+          else
+            echo "Playwright not found, skipping browser installation"
+          fi
+        continue-on-error: true
+
+      - name: Update VS Code type definitions
+        run: yarn update-dts
+
+      - name: Basic build verification
+        run: |
+          echo "Verifying basic setup..."
+          if [ ! -d "node_modules" ]; then
+            echo "❌ node_modules not found"
+            exit 1
+          fi
+          if [ ! -f "node_modules/.bin/tsc" ]; then
+            echo "❌ TypeScript compiler not found"
+            exit 1
+          fi
+          if [ ! -f "node_modules/.bin/webpack" ]; then
+            echo "❌ Webpack not found"
+            exit 1
+          fi
+          echo "✅ Basic setup verification successful"

.github/workflows/copilot-setup-steps.yml

@@ -2,3 +2,4 @@
 . "$(dirname -- "$0")/_/husky.sh"
 
 npm run hygiene
+npm run lint

.husky/pre-commit

@@ -92,6 +92,7 @@
 				"--extensionDevelopmentPath=${workspaceFolder}",
 				"--extensionTestsPath=${workspaceFolder}/out/src/test",
 				"--disable-extensions",
+				"--user-data-dir=${workspaceFolder}/.vscode-test"
 			],
 			"preLaunchTask": "npm: test:preprocess",
 			"smartStep": true,
@@ -101,12 +102,11 @@
 			"type": "node",
 			"request": "launch",
 			"name": "Attach Web Test",
-			"program": "${workspaceFolder}/node_modules/vscode-test-web/out/index.js",
+			"program": "${workspaceFolder}/node_modules/@vscode/test-web/out/server/index.js",
 			"args": [
 				"--extensionTestsPath=dist/browser/test/index.js",
 				"--extensionDevelopmentPath=.",
 				"--browserType=chromium",
-				"--attach=9229"
 			],
 			"cascadeTerminateToConfigurations": [
 				"Launch Web Test"

.vscode/launch.json

@@ -4,6 +4,14 @@
 		".eslintrc.json": "jsonc",
 		".eslintrc.*.json": "jsonc"
 	},
+	"json.schemas": [
+		{
+			"fileMatch": [
+				"**/.eslintrc.*.json"
+			],
+			"url": "https://json.schemastore.org/eslintrc"
+		}
+	],
 	"files.trimTrailingWhitespace": true,
 	"gitlens.advanced.blame.customArguments": ["--ignore-revs-file", ".gitignore-revs"]
 }

.vscode/settings.json

@@ -28,6 +28,7 @@ azure-pipeline.*
 yarn.lock
 **/*.map
 **/*.svg
+!**/output.svg
 !**/pr_webview.svg
 **/*.ts
 *.vsix