agent sessions - narrow down event blockage on anchor elements in markdown only (#276345)

* agent sessions - narrow down event blockage on anchor elements in markdown only

* .

* .

Author: bpasero

src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts

@@ -144,22 +144,27 @@ export class AgentSessionRenderer implements ICompressibleTreeRenderer<IAgentSes
 		if (typeof session.element.description === 'string') {
 			template.description.textContent = session.element.description;
 		} else {
-			template.elementDisposable.add(this.markdownRendererService.render(session.element.description, {
+			const descriptionMarkdown = this.markdownRendererService.render(session.element.description, {
 				sanitizerConfig: {
 					replaceWithPlaintext: true,
 					allowedTags: {
 						override: allowedChatMarkdownHtmlTags,
 					},
 					allowedLinkSchemes: { augment: [this.productService.urlProtocol] }
 				},
-			}, template.description));
-
-			// TODO@bpasero this is needed so that a user can click into a link of the session
-			// without opening the session itself. Revisit this approach as we want to move
-			// away from allowing different results based on where the user clicks.
-			template.elementDisposable.add(addDisposableListener(template.description, EventType.MOUSE_DOWN, e => e.stopPropagation()));
-			template.elementDisposable.add(addDisposableListener(template.description, EventType.CLICK, e => e.stopPropagation()));
-			template.elementDisposable.add(addDisposableListener(template.description, EventType.AUXCLICK, e => e.stopPropagation()));
+			}, template.description);
+			template.elementDisposable.add(descriptionMarkdown);
+
+			// Prevent link clicks from opening the session itself
+			// by stopping propagation of mouse events from links
+			// within (TODO@bpasero revisit this in the future).
+			// eslint-disable-next-line no-restricted-syntax
+			const anchors = descriptionMarkdown.element.querySelectorAll('a');
+			for (const anchor of anchors) {
+				template.elementDisposable.add(addDisposableListener(anchor, EventType.MOUSE_DOWN, e => e.stopPropagation()));
+				template.elementDisposable.add(addDisposableListener(anchor, EventType.CLICK, e => e.stopPropagation()));
+				template.elementDisposable.add(addDisposableListener(anchor, EventType.AUXCLICK, e => e.stopPropagation()));
+			}
 		}
 
 		// Status (updated every minute)

src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsactions.css

@@ -16,15 +16,24 @@
 		padding: 0 4px 0 0; /* to make space for hover effect */
 	}
 
-	span.agent-session-diff-files {
+	.agent-session-diff-files {
 		color: var(--vscode-descriptionForeground);
 	}
 
-	span.agent-session-diff-added {
+	.agent-session-diff-added {
 		color: var(--vscode-chat-linesAddedForeground);
 	}
 
-	span.agent-session-diff-removed {
+	.agent-session-diff-removed {
 		color: var(--vscode-chat-linesRemovedForeground);
 	}
 }
+
+.monaco-list-row.selected .agent-session-item .agent-session-toolbar {
+
+	.agent-session-diff-files,
+	.agent-session-diff-added,
+	.agent-session-diff-removed {
+		color: unset;
+	}
+}