loading instructions on demand needs agent mode (#256675)

Author: aeschli

src/vs/workbench/contrib/chat/browser/chatWidget.ts

@@ -51,7 +51,7 @@ import { ChatViewModel, IChatRequestViewModel, IChatResponseViewModel, isRequest
 import { IChatInputState } from '../common/chatWidgetHistoryService.js';
 import { CodeBlockModelCollection } from '../common/codeBlockModelCollection.js';
 import { ChatAgentLocation, ChatConfiguration, ChatModeKind } from '../common/constants.js';
-import { ILanguageModelToolsService, ToolSet } from '../common/languageModelToolsService.js';
+import { ILanguageModelToolsService, IToolData, ToolSet } from '../common/languageModelToolsService.js';
 import { type TPromptMetadata } from '../common/promptSyntax/parsers/promptHeader/promptHeader.js';
 import { IPromptParserResult, IPromptsService } from '../common/promptSyntax/service/promptsService.js';
 import { handleModeSwitch } from './actions/chatActions.js';
@@ -1986,12 +1986,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
 		this.logService.debug(`ChatWidget#_autoAttachInstructions: ${PromptsConfig.KEY}: ${promptsConfigEnabled}`);
 
 		if (promptsConfigEnabled) {
-			let readFileTool = this.toolsService.getToolByName('readFile');
-			if (readFileTool && this.getUserSelectedTools()?.[readFileTool.id] === false) {
-				readFileTool = undefined;
-			}
-
-			const computer = this.instantiationService.createInstance(ComputeAutomaticInstructions, readFileTool);
+			const computer = this.instantiationService.createInstance(ComputeAutomaticInstructions, this._getReadFileTool());
 			await computer.collect(attachedContext, CancellationToken.None);
 		} else {
 			const computer = this.instantiationService.createInstance(ComputeAutomaticInstructions, undefined);
@@ -2000,6 +1995,19 @@ export class ChatWidget extends Disposable implements IChatWidget {
 
 		// add to attached list to make the instructions sticky
 		//this.inputPart.attachmentModel.addContext(...computer.autoAddedInstructions);
+
+	}
+
+	private _getReadFileTool(): IToolData | undefined {
+		if (this.input.currentModeKind !== ChatModeKind.Agent) {
+			return undefined;
+		}
+
+		const readFileTool = this.toolsService.getToolByName('readFile');
+		if (readFileTool && this.getUserSelectedTools()?.[readFileTool.id] === false) {
+			return undefined;
+		}
+		return readFileTool;
 	}
 }