Skip to content

Add missing isMeasurement flags to telemetry events in chatWidget.ts #272518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Add missing isMeasurement flags to telemetry events in chatWidget.ts #272518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c8f649
Initial plan
Copilot Oct 21, 2025
8f96ee5
Add isMeasurement flags to telemetry classifications in chatWidget.ts
Copilot Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vs/workbench/contrib/chat/browser/chatWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2095,7 +2095,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
type CancelRequestEventEditClassification = {
owner: 'justschen';
editRequestType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Current entry point for editing a request.' };
editCanceled: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Indicates whether the edit was canceled.' };
editCanceled: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Indicates whether the edit was canceled.' };
comment: 'Event used to gain insights into when edits are being canceled.';
};

Expand Down Expand Up @@ -2672,8 +2672,8 @@ export class ChatWidget extends Disposable implements IChatWidget {
type ChatEditingWorkingSetClassification = {
owner: 'joyceerhl';
comment: 'Information about the working set size in a chat editing request';
originalSize: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The number of files that the user tried to attach in their editing request.' };
actualSize: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The number of files that were actually sent in their editing request.' };
originalSize: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'The number of files that the user tried to attach in their editing request.' };
actualSize: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'The number of files that were actually sent in their editing request.' };
};
type ChatEditingWorkingSetEvent = {
originalSize: number;
Expand Down
Loading