-
Notifications
You must be signed in to change notification settings - Fork 36.1k
make terminal output feature accessible to screen reader users #276211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an accessible view for chat terminal tool output, allowing screen reader users to access terminal command output from chat tool invocations. It also renames the TerminalChat accessibility verbosity setting to TerminalInlineChat for clarity.
Key changes:
- Adds new
ChatTerminalOutputAccessibleViewto provide accessible terminal output content - Introduces
inChatTerminalToolOutputcontext key to track focus state - Renames
AccessibilityVerbositySettingId.TerminalChattoTerminalInlineChatfor consistency - Adds new
TerminalChatOutputverbosity setting for the terminal output accessible view - Implements focus tracking and aria-label management in
ChatTerminalToolProgressPart
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatAccessibilityHelp.ts | Updates reference from TerminalChat to TerminalInlineChat setting ID |
| src/vs/workbench/contrib/terminalContrib/chat/browser/terminal.initialHint.contribution.ts | Updates two references from TerminalChat to TerminalInlineChat setting ID |
| src/vs/workbench/contrib/chat/common/chatContextKeys.ts | Adds new context key for terminal tool output focus tracking |
| src/vs/workbench/contrib/chat/browser/chatTerminalOutputAccessibleView.ts | New file implementing the accessible view for terminal output |
| src/vs/workbench/contrib/chat/browser/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts | Adds focus tracking, aria-label management, and accessible view support |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Registers the new ChatTerminalOutputAccessibleView |
| src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts | Renames TerminalChat to TerminalInlineChat and adds new TerminalChatOutput setting |
| src/vs/platform/accessibility/browser/accessibleView.ts | Adds ChatTerminalOutput provider ID |
...ch/contrib/chat/browser/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts
Outdated
Show resolved
Hide resolved
...ch/contrib/chat/browser/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts
Show resolved
Hide resolved
…ocationParts/chatTerminalToolProgressPart.ts Co-authored-by: Copilot <[email protected]>
fix #274220
If/when we end up using xterm here instead, we can reuse all of this and just change the
getCommandAndOutputAsTextfunction.