Handle invalid (legacy) cache data

Author: dshafik

src/Unleash.php

@@ -137,13 +137,17 @@ protected function getCachedFeatures(): FeatureFlagCollection
         }
 
         if ($this->config->get('unleash.cache.isEnabled')) {
-            return $this->cache->remember(
+            $features = $this->cache->remember(
                 'unleash',
                 $this->config->get('unleash.cache.ttl', self::DEFAULT_CACHE_TTL),
                 function () {
                     return $this->fetchFeatures();
                 }
             );
+            if ($features instanceof FeatureFlagCollection) {
+                return $features;
+            }
+            $this->cache->forget('unleash');
         }
 
         return $this->features ?? $this->features = $this->fetchFeatures();

src/Values/FeatureFlag.php

@@ -241,6 +241,34 @@ protected function findVariant(int $stickiness)
 
     protected function randomString(): string
     {
-        return bin2hex(random_bytes(random_int(0, 100000)));
+        return bin2hex(random_bytes(random_int(1, 100000)));
+    }
+
+    public function __serialize(): array
+    {
+        return [
+            'enabled' => $this->enabled,
+            'name' => $this->name,
+            'description' => $this->description,
+            'project' => $this->project,
+            'stale' => $this->stale,
+            'type' => $this->type,
+            'strategies' => $this->strategies->toArray(),
+            'variants' => $this->variants->toArray(),
+        ];
+    }
+
+    public function __unserialize(array $data): void
+    {
+        $this->unleash = resolve(Unleash::class);
+        $this->enabled = $data['enabled'];
+        $this->name = $data['name'];
+        $this->description = $data['description'];
+        $this->project = $data['project'];
+        $this->stale = $data['stale'];
+        $this->type = $data['type'];
+
+        $this->strategies = Collection::make($data['strategies']);
+        $this->variants = Collection::make($data['variants']);
     }
 }

tests/MockClient.php

@@ -8,8 +8,14 @@
 
 trait MockClient
 {
+    /**
+     * @var MockHandler
+     */
     protected $mockHandler;
 
+    /**
+     * @var Client
+     */
     protected $client;
 
     protected function setUp(): void