Commit f8d417c
authored
do not check brentq is NotImplemented
* related to pvlib#556
* if brentq can't be imported it will raise a `NotImplementedError` alread
* lgtm says it's better for a callable to have a consistent API
* that's why we changed it the not-imported `brentq` from `NotImplemented` to a callable, b/c `brentq` is usually callable
* but we forgot the original code has a check if `brentq` is `NotImplemented`, so we can remove that now1 parent 38a52b1 commit f8d417c
1 file changed
+0
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | | - | |
213 | | - | |
214 | 212 | | |
215 | 213 | | |
216 | 214 | | |
| |||
275 | 273 | | |
276 | 274 | | |
277 | 275 | | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | 276 | | |
282 | 277 | | |
283 | 278 | | |
| |||
336 | 331 | | |
337 | 332 | | |
338 | 333 | | |
339 | | - | |
340 | | - | |
341 | 334 | | |
342 | 335 | | |
343 | 336 | | |
| |||
0 commit comments