fix: [2.6] segcore collection schema update not concurrent safe. #45618

aoiasd · 2025-11-17T07:44:11Z

relate: #45345
pr: #45337

sre-ci-robot · 2025-11-17T07:45:01Z

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

/ci-rerun-code-check // for ci-v2/code-check
/ci-rerun-build // for ci-v2/build
/ci-rerun-ut-integration // for ci-v2/ut-integration
/ci-rerun-ut-go // for ci-v2/ut-go
/ci-rerun-ut-cpp // for ci-v2/ut-cpp
/ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
/ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot · 2025-11-17T07:45:19Z

[INFO] PR Label Summary by Default
[SUCCESS] PR #45337 merged to master

Title: fix: segcore collection schema update not concurrent safe.
Link: fix: segcore collection schema update not concurrent safe. #45337

[WARNING] Milestone not set

PR: fix: [2.6] segcore collection schema update not concurrent safe. #45618
Title: fix: [2.6] segcore collection schema update not concurrent safe.
Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

aoiasd · 2025-11-17T07:51:10Z

/set-milestone 2.5.7

sre-ci-robot · 2025-11-17T07:51:39Z

[ERROR] Failed to set milestone: 2.5.7

mergify · 2025-11-17T08:55:33Z

@aoiasd cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

codecov · 2025-11-17T09:55:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (cb08db0) to head (dcd35ee).
⚠️ Report is 277 commits behind head on 2.6.

❌ Your project status has failed because the head coverage (76.60%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##              2.6   #45618      +/-   ##
==========================================
- Coverage   76.99%   76.60%   -0.39%     
==========================================
  Files        1700     1856     +156     
  Lines      262533   287764   +25231     
==========================================
+ Hits       202142   220447   +18305     
- Misses      53550    59971    +6421     
- Partials     6841     7346     +505

Components	Coverage Δ
Client	`78.03% <65.76%> (-0.11%)`	⬇️
Core	`83.65% <79.25%> (+1.44%)`	⬆️
Go	`74.62% <52.20%> (-0.77%)`	⬇️

Files with missing lines	Coverage Δ
internal/core/src/common/Schema.h	`98.95% <ø> (ø)`
internal/core/src/segcore/Collection.cpp	`70.45% <100.00%> (-1.29%)`	⬇️
internal/core/src/segcore/Collection.h	`100.00% <100.00%> (ø)`

... and 647 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sre-ci-robot · 2025-11-18T06:27:44Z

[INFO] PR Label Summary by Default
[SUCCESS] PR #45337 merged to master

Title: fix: segcore collection schema update not concurrent safe.
Link: fix: segcore collection schema update not concurrent safe. #45337

[WARNING] Milestone not set

PR: fix: [2.6] segcore collection schema update not concurrent safe. #45618
Title: fix: [2.6] segcore collection schema update not concurrent safe.
Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

aoiasd · 2025-11-19T02:24:48Z

/set-milestone 2.6.5

sre-ci-robot · 2025-11-19T02:25:12Z

[ERROR] Failed to set milestone: 2.6.5

aoiasd · 2025-11-19T02:25:57Z

/set-milestone 2.6.6

sre-ci-robot · 2025-11-19T02:26:27Z

[INFO] Set milestone to: 2.6.6

sre-ci-robot · 2025-11-19T03:29:20Z

[INFO] PR Label Summary by Default
[SUCCESS] PR #45337 merged to master

Title: fix: segcore collection schema update not concurrent safe.
Link: fix: segcore collection schema update not concurrent safe. #45337

Use /refresh-label to update related check and label manually

mergify · 2025-11-19T05:05:01Z

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2025-11-19T08:37:43Z

@aoiasd cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

aoiasd · 2025-11-20T02:20:02Z

/run-cpu-e2e

aoiasd · 2025-11-20T02:20:09Z

rerun go-sdk

aoiasd · 2025-11-20T02:20:18Z

/ci-rerun-ut-integration

mergify · 2025-11-20T03:03:11Z

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

sre-ci-robot · 2025-11-20T05:07:38Z

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

/ci-rerun-code-check // for ci-v2/code-check
/ci-rerun-build // for ci-v2/build
/ci-rerun-ut-integration // for ci-v2/ut-integration
/ci-rerun-ut-go // for ci-v2/ut-go
/ci-rerun-ut-cpp // for ci-v2/ut-cpp
/ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
/ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

aoiasd · 2025-11-20T09:36:09Z

rerun go-sdk

aoiasd · 2025-11-20T09:36:29Z

/run-cpu-e2e

…#45337) relate: milvus-io#45345 Signed-off-by: aoiasd <[email protected]>

sre-ci-robot · 2025-11-21T02:50:05Z

[INFO] PR Label Summary by Default
[SUCCESS] PR #45337 merged to master

Title: fix: segcore collection schema update not concurrent safe.
Link: fix: segcore collection schema update not concurrent safe. #45337

Use /refresh-label to update related check and label manually

congqixia

/lgtm

sre-ci-robot · 2025-11-25T02:32:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~internal/core/OWNERS~~ [congqixia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot · 2025-11-25T02:33:23Z

[INFO] PR Label Summary by Default
[SUCCESS] PR #45337 merged to master

Title: fix: segcore collection schema update not concurrent safe.
Link: fix: segcore collection schema update not concurrent safe. #45337

Use /refresh-label to update related check and label manually

sre-ci-robot requested review from czs007 and godchen0212 November 17, 2025 07:44

sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 17, 2025

mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 17, 2025

sre-ci-robot added the do-not-merge/need-milestone generate by v2-label-manager label Nov 17, 2025

aoiasd force-pushed the C5 branch from d0ccb25 to 31910d3 Compare November 18, 2025 06:26

sre-ci-robot added this to the 2.6.6 milestone Nov 19, 2025

sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Nov 19, 2025

aoiasd force-pushed the C5 branch from 31910d3 to 7c7dfbf Compare November 19, 2025 03:28

fix: segcore collection schema update not concurrent safe. (milvus-io…

dcd35ee

…#45337) relate: milvus-io#45345 Signed-off-by: aoiasd <[email protected]>

aoiasd force-pushed the C5 branch from 7c7dfbf to dcd35ee Compare November 21, 2025 02:48

mergify bot added the ci-passed label Nov 21, 2025

yanliang567 modified the milestones: 2.6.6, 2.6.7 Nov 21, 2025

congqixia approved these changes Nov 25, 2025

View reviewed changes

sre-ci-robot assigned congqixia Nov 25, 2025

sre-ci-robot added the lgtm label Nov 25, 2025

sre-ci-robot added the approved label Nov 25, 2025

sre-ci-robot merged commit b92f17b into milvus-io:2.6 Nov 25, 2025
14 of 19 checks passed

fix: [2.6] segcore collection schema update not concurrent safe. #45618

fix: [2.6] segcore collection schema update not concurrent safe. #45618

Uh oh!

Conversation

aoiasd commented Nov 17, 2025

Uh oh!

sre-ci-robot commented Nov 17, 2025

Uh oh!

sre-ci-robot commented Nov 17, 2025

Uh oh!

aoiasd commented Nov 17, 2025

Uh oh!

sre-ci-robot commented Nov 17, 2025

Uh oh!

mergify bot commented Nov 17, 2025

Uh oh!

codecov bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sre-ci-robot commented Nov 18, 2025

Uh oh!

aoiasd commented Nov 19, 2025

Uh oh!

sre-ci-robot commented Nov 19, 2025

Uh oh!

aoiasd commented Nov 19, 2025

Uh oh!

sre-ci-robot commented Nov 19, 2025

Uh oh!

sre-ci-robot commented Nov 19, 2025

Uh oh!

mergify bot commented Nov 19, 2025

Uh oh!

mergify bot commented Nov 19, 2025

Uh oh!

aoiasd commented Nov 20, 2025

Uh oh!

aoiasd commented Nov 20, 2025

Uh oh!

aoiasd commented Nov 20, 2025

Uh oh!

mergify bot commented Nov 20, 2025

Uh oh!

sre-ci-robot commented Nov 20, 2025

Uh oh!

aoiasd commented Nov 20, 2025

Uh oh!

aoiasd commented Nov 20, 2025

Uh oh!

sre-ci-robot commented Nov 21, 2025

Uh oh!

congqixia left a comment

Choose a reason for hiding this comment

Uh oh!

sre-ci-robot commented Nov 25, 2025

Uh oh!

Uh oh!

sre-ci-robot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Nov 17, 2025 •

edited

Loading