InitDevices: handle device denied reason and PartTableType (#1000)

* Return error if denied device is passed
* Use force flag if device PartTableType is set

Signed-off-by: Bala.FA <[email protected]>

Author: balamurugana

pkg/device/probe.go

@@ -101,6 +101,11 @@ func (d Device) Make() string {
 	return strings.Join(tokens, " ")
 }
 
+// PartTableType returns partition table type.
+func (d Device) PartTableType() string {
+	return d.udevData["E:ID_PART_TABLE_TYPE"]
+}
+
 // FSType returns filesystem type.
 func (d Device) FSType() string {
 	return d.udevData["E:ID_FS_TYPE"]
@@ -111,8 +116,8 @@ func (d Device) FSUUID() string {
 	return d.udevData["E:ID_FS_UUID"]
 }
 
-// deniedReason returns the reason if the device is denied for initialization.
-func (d Device) deniedReason() string {
+// DeniedReason returns the reason if the device is denied for initialization.
+func (d Device) DeniedReason() string {
 	var reasons []string
 
 	if d.Size < minSupportedDeviceSize {
@@ -175,7 +180,7 @@ func (d Device) ToNodeDevice(nodeID directpvtypes.NodeID) types.Device {
 		Make:         d.Make(),
 		FSType:       d.FSType(),
 		FSUUID:       d.FSUUID(),
-		DeniedReason: d.deniedReason(),
+		DeniedReason: d.DeniedReason(),
 	}
 }
 

pkg/initrequest/event.go

@@ -191,15 +191,19 @@ func (handler *initRequestEventHandler) initDevices(ctx context.Context, req *ty
 		case !found:
 			results[i].Error = "device not found"
 		case device.ID(handler.nodeID) != req.Spec.Devices[i].ID:
-			results[i].Error = "device's state changed"
+			results[i].Error = "device state changed"
 		default:
-			wg.Add(1)
-			go func(i int, device pkgdevice.Device, force bool) {
-				defer wg.Done()
-				if err := handler.initDevice(device, force); err != nil {
-					results[i].Error = err.Error()
-				}
-			}(i, device, req.Spec.Devices[i].Force)
+			if deniedReason := device.DeniedReason(); deniedReason == "" {
+				wg.Add(1)
+				go func(i int, device pkgdevice.Device, force bool) {
+					defer wg.Done()
+					if err := handler.initDevice(device, force); err != nil {
+						results[i].Error = err.Error()
+					}
+				}(i, device, req.Spec.Devices[i].Force || device.PartTableType() != "")
+			} else {
+				results[i].Error = "device init not permitted; " + deniedReason
+			}
 		}
 	}
 	wg.Wait()