Upgrade go v1.24.1 (#990)

Signed-off-by: Bala.FA <[email protected]>

Author: balamurugana

.github/workflows/build.yml

@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.23.x
+          go-version: 1.24.x
           check-latest: true
       - name: Set environment
         run: |

.github/workflows/functests.yml

@@ -27,7 +27,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.23.x
+          go-version: 1.24.x
           check-latest: true
 
       - name: Install dependencies

.github/workflows/linters.yml

@@ -20,10 +20,10 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.23.x
+          go-version: 1.24.x
           check-latest: true
       - uses: ludeeus/action-shellcheck@master
       - uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.62.0
+          version: v1.64.8
           args: --config ./.golangci.yml --timeout=60m

.github/workflows/vulncheck.yml

@@ -23,7 +23,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.23.x
+        go-version: 1.24.x
         check-latest: true
     - name: Install govulncheck
       run: go install golang.org/x/vuln/cmd/govulncheck@latest

.golangci.yml

@@ -1,10 +1,10 @@
 linters-settings:
-run:
-  go: "1.23"
-
   misspell:
     locale: US
 
+run:
+  go: "1.24"
+
 linters:
   disable-all: true
   enable:
@@ -20,7 +20,7 @@ linters:
     - unused
     - gocritic
     - gofumpt
-    - tenv
+    - usetesting
     - durationcheck
     - staticcheck
 
@@ -30,6 +30,3 @@ issues:
     - should have a package comment
     - exitAfterDefer
     - redefines-builtin-id
-
-service:
-  golangci-lint-version: 1.62.0 # use the fixed version to not introduce new linters unexpectedly

.goreleaser.yml

@@ -17,7 +17,7 @@ release:
 
 before:
   hooks:
-    - go mod tidy -compat=1.23
+    - go mod tidy -compat=1.24
     - go mod download
 
 builds:
@@ -64,7 +64,7 @@ builds:
 
 archives:
   - allow_different_binary_count: true
-    format: binary
+    formats: [ 'binary' ]
 
 changelog:
   sort: asc

go.mod

@@ -1,8 +1,8 @@
 module github.com/minio/directpv
 
-go 1.23.0
+go 1.24.0
 
-toolchain go1.23.3
+toolchain go1.24.1
 
 require (
 	github.com/charmbracelet/bubbles v0.20.0

pkg/admin/installer/installer_test.go

@@ -17,7 +17,6 @@
 package installer
 
 import (
-	"context"
 	"io"
 	"testing"
 
@@ -125,7 +124,7 @@ func TestInstallUinstall(t *testing.T) {
 		client := client.GetClient()
 		legacyClient := legacyclient.GetClient()
 		client.K8sClient.DiscoveryClient = k8s.NewFakeDiscovery(getDiscoveryGroupsAndMethods, &testVersion)
-		ctx := context.TODO()
+		ctx := t.Context()
 		args := args
 		tasks := GetDefaultTasks(client, legacyClient)
 		if err := Install(ctx, &args, tasks); err != nil {

pkg/admin/installer/migrate_test.go

@@ -17,7 +17,6 @@
 package installer
 
 import (
-	"context"
 	"reflect"
 	"testing"
 
@@ -42,7 +41,7 @@ func TestMigrateDrivesError(t *testing.T) {
 
 	legacyclient.SetDriveClient(legacyclientsetfake.NewSimpleClientset(drive))
 	task := migrateTask{client.GetClient(), legacyclient.GetClient()}
-	driveMap, legacyDriveErrors, driveErrors, err := task.migrateDrives(context.TODO(), false, nil)
+	driveMap, legacyDriveErrors, driveErrors, err := task.migrateDrives(t.Context(), false, nil)
 	if len(driveMap) == 0 && len(legacyDriveErrors) == 0 && len(driveErrors) == 0 && err == nil {
 		t.Fatalf("expected error, but succeeded\n")
 	}
@@ -56,7 +55,7 @@ func TestMigrateDrivesError(t *testing.T) {
 		},
 	}
 	legacyclient.SetDriveClient(legacyclientsetfake.NewSimpleClientset(drive))
-	driveMap, legacyDriveErrors, driveErrors, err = task.migrateDrives(context.TODO(), false, nil)
+	driveMap, legacyDriveErrors, driveErrors, err = task.migrateDrives(t.Context(), false, nil)
 	if len(driveMap) == 0 && len(legacyDriveErrors) == 0 && len(driveErrors) == 0 && err == nil {
 		t.Fatalf("expected error, but succeeded\n")
 	}
@@ -79,7 +78,7 @@ func TestMigrateDrivesError(t *testing.T) {
 		},
 	}
 	legacyclient.SetDriveClient(legacyclientsetfake.NewSimpleClientset(drive1, drive2))
-	driveMap, legacyDriveErrors, driveErrors, err = task.migrateDrives(context.TODO(), false, nil)
+	driveMap, legacyDriveErrors, driveErrors, err = task.migrateDrives(t.Context(), false, nil)
 	if len(driveMap) == 0 && len(legacyDriveErrors) == 0 && len(driveErrors) == 0 && err == nil {
 		t.Fatalf("expected error, but succeeded\n")
 	}
@@ -90,11 +89,11 @@ func TestMigrateNoDrives(t *testing.T) {
 	clientset := types.NewExtFakeClientset(clientsetfake.NewSimpleClientset())
 	client.SetDriveInterface(clientset.DirectpvLatest().DirectPVDrives())
 	task := migrateTask{client.GetClient(), legacyclient.GetClient()}
-	_, legacyDriveErrors, driveErrors, err := task.migrateDrives(context.TODO(), false, nil)
+	_, legacyDriveErrors, driveErrors, err := task.migrateDrives(t.Context(), false, nil)
 	if len(legacyDriveErrors) != 0 || len(driveErrors) != 0 || err != nil {
 		t.Fatalf("unexpected error; %v\n", err)
 	}
-	driveList, err := client.DriveClient().List(context.TODO(), metav1.ListOptions{})
+	driveList, err := client.DriveClient().List(t.Context(), metav1.ListOptions{})
 	if err != nil && !apierrors.IsNotFound(err) {
 		t.Fatalf("unexpected error; %v\n", err)
 	}
@@ -116,11 +115,11 @@ func TestMigrateNoDrives(t *testing.T) {
 	clientset = types.NewExtFakeClientset(clientsetfake.NewSimpleClientset())
 	client.SetDriveInterface(clientset.DirectpvLatest().DirectPVDrives())
 
-	_, legacyDriveErrors, driveErrors, err = task.migrateDrives(context.TODO(), false, nil)
+	_, legacyDriveErrors, driveErrors, err = task.migrateDrives(t.Context(), false, nil)
 	if len(legacyDriveErrors) != 0 || len(driveErrors) != 0 || err != nil {
 		t.Fatalf("unexpected error; %v\n", err)
 	}
-	driveList, err = client.DriveClient().List(context.TODO(), metav1.ListOptions{})
+	driveList, err = client.DriveClient().List(t.Context(), metav1.ListOptions{})
 	if err != nil && !apierrors.IsNotFound(err) {
 		t.Fatalf("unexpected error; %v\n", err)
 	}
@@ -206,15 +205,15 @@ func TestMigrateReadyDrive(t *testing.T) {
 	clientset := types.NewExtFakeClientset(clientsetfake.NewSimpleClientset())
 	client.SetDriveInterface(clientset.DirectpvLatest().DirectPVDrives())
 	task := migrateTask{client.GetClient(), legacyclient.GetClient()}
-	driveMap, legacyDriveErrors, driveErrors, err := task.migrateDrives(context.TODO(), false, nil)
+	driveMap, legacyDriveErrors, driveErrors, err := task.migrateDrives(t.Context(), false, nil)
 	if len(legacyDriveErrors) != 0 || len(driveErrors) != 0 || err != nil {
 		t.Fatalf("unexpected error; %v, %v, %v\n", legacyDriveErrors, driveErrors, err)
 	}
 	if len(driveMap) == 0 {
 		t.Fatalf("empty drive map\n")
 	}
 
-	result, err := client.DriveClient().Get(context.TODO(), "08450612-7ab3-40f9-ab83-38645fba6d29", metav1.GetOptions{})
+	result, err := client.DriveClient().Get(t.Context(), "08450612-7ab3-40f9-ab83-38645fba6d29", metav1.GetOptions{})
 	if err != nil {
 		t.Fatalf("unexpected error; %v\n", err)
 	}
@@ -342,15 +341,15 @@ func TestMigrateInUseDrive(t *testing.T) {
 	clientset := types.NewExtFakeClientset(clientsetfake.NewSimpleClientset())
 	client.SetDriveInterface(clientset.DirectpvLatest().DirectPVDrives())
 	task := migrateTask{client.GetClient(), legacyclient.GetClient()}
-	driveMap, legacyDriveErrors, driveErrors, err := task.migrateDrives(context.TODO(), false, nil)
+	driveMap, legacyDriveErrors, driveErrors, err := task.migrateDrives(t.Context(), false, nil)
 	if len(legacyDriveErrors) != 0 || len(driveErrors) != 0 || err != nil {
 		t.Fatalf("unexpected error; %v, %v, %v\n", legacyDriveErrors, driveErrors, err)
 	}
 	if len(driveMap) == 0 {
 		t.Fatalf("empty drive map\n")
 	}
 
-	result, err := client.DriveClient().Get(context.TODO(), "08450612-7ab3-40f9-ab83-38645fba6d29", metav1.GetOptions{})
+	result, err := client.DriveClient().Get(t.Context(), "08450612-7ab3-40f9-ab83-38645fba6d29", metav1.GetOptions{})
 	if err != nil {
 		t.Fatalf("unexpected error; %v\n", err)
 	}
@@ -454,7 +453,7 @@ func TestMigrateVolumes(t *testing.T) {
 	client.SetVolumeInterface(clientset.DirectpvLatest().DirectPVVolumes())
 	task := migrateTask{client.GetClient(), legacyclient.GetClient()}
 	legacyVolumeErrors, volumeErrors, err := task.migrateVolumes(
-		context.TODO(),
+		t.Context(),
 		map[string]string{"08450612-7ab3-40f9-ab83-38645fba6d29": "a9908089-96dd-4e8b-8f06-0c0b5e391f39"},
 		false,
 		nil,
@@ -463,7 +462,7 @@ func TestMigrateVolumes(t *testing.T) {
 		t.Fatalf("unexpected error; %v, %v, %v\n", legacyVolumeErrors, volumeErrors, err)
 	}
 
-	result, err := client.VolumeClient().Get(context.TODO(), "pvc-009bfc49-4a66-4055-9f19-bd039cc3b4f5", metav1.GetOptions{})
+	result, err := client.VolumeClient().Get(t.Context(), "pvc-009bfc49-4a66-4055-9f19-bd039cc3b4f5", metav1.GetOptions{})
 	if err != nil {
 		t.Fatalf("unexpected error; %v\n", err)
 	}
@@ -493,7 +492,7 @@ func TestMigrateVolumes(t *testing.T) {
 
 	// no fsuuid found error
 	legacyclient.SetVolumeClient(legacyclientsetfake.NewSimpleClientset(volume))
-	legacyVolumeErrors, volumeErrors, err = task.migrateVolumes(context.TODO(), map[string]string{}, false, nil)
+	legacyVolumeErrors, volumeErrors, err = task.migrateVolumes(t.Context(), map[string]string{}, false, nil)
 	if len(legacyVolumeErrors) == 0 && len(volumeErrors) == 0 && err == nil {
 		t.Fatalf("expected error; but succeeded\n")
 	}

pkg/client/drive_lister_test.go

@@ -17,7 +17,6 @@
 package client
 
 import (
-	"context"
 	"fmt"
 	"testing"
 
@@ -30,7 +29,7 @@ import (
 func TestGetDriveList(t *testing.T) {
 	clientset := types.NewExtFakeClientset(clientsetfake.NewSimpleClientset())
 	SetDriveInterface(clientset.DirectpvLatest().DirectPVDrives())
-	drives, err := client.NewDriveLister().Get(context.TODO())
+	drives, err := client.NewDriveLister().Get(t.Context())
 	if err != nil {
 		t.Fatalf("unexpected error: %v", err)
 	}
@@ -47,7 +46,7 @@ func TestGetDriveList(t *testing.T) {
 
 	clientset = types.NewExtFakeClientset(clientsetfake.NewSimpleClientset(objects...))
 	SetDriveInterface(clientset.DirectpvLatest().DirectPVDrives())
-	drives, err = client.NewDriveLister().Get(context.TODO())
+	drives, err = client.NewDriveLister().Get(t.Context())
 	if err != nil {
 		t.Fatalf("unexpected error: %v", err)
 	}