chore: warn if shared dependency is resolved to somewhere (#354) #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gioboa
reviewed
Nov 18, 2025
Collaborator
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Thanks @CaptainWang98 for your help 💪
gioboa
changed the title
gioboa
approved these changes
Nov 19, 2025
Collaborator
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Thanks @CaptainWang98
LGTM 👏
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #354 #282
In vite,
resolve.aliashas higher priority than MF.Accidently, user may point shared dependency to somewhere else:
https://github.com/neversleeppy/mf-vite-slot/blob/main/host/vite.config.ts
This may cause unexpected runtime behavior.
This PR will detect conflict between
resolve.aliasandMF.shared, and then show warn in build-time.