Skip to content

Commit ffc9b17

Browse files
committed
ci(GitHub): Run workflows also with Python 3.14 (aka, πthon)
Fix a few finally blocks using (break/continue/return) that are not allowed with Python 3.14 and up.
1 parent f8be95d commit ffc9b17

File tree

5 files changed

+16
-7
lines changed

5 files changed

+16
-7
lines changed

.github/workflows/test-and-docker.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ jobs:
1616
include:
1717
- python: '3.12'
1818
- python: '3.13'
19+
- python: '3.14'
1920
steps:
2021
- name: Checkout
2122
uses: actions/checkout@v5

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html),
77
and commits should be formatted using [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/).
88

9+
## [Unreleased]
10+
11+
### Changed
12+
13+
- GitHub: Run GH workflows also with Python 3.14 (aka, πthon).
914
## [0.11.2] - 2025-10-22
1015

1116
### Added
@@ -21,6 +26,10 @@ and commits should be formatted using [Conventional Commits](https://www.convent
2126

2227
- Indexing: Avoid name clashes when finding the JSON file to index by @stronk7 ([7ac9dde](https://github.com/moodlehq/wiki-rag/commit/7ac9ddeb75aafb4a3a0ddda5a333de9b722e3312))
2328

29+
### New Contributors 🧡:
30+
31+
- @stronk7 made their first contribution
32+
2433
**Full Changelog**: https://github.com/moodlehq/wiki-rag/compare/v0.11.1...v0.11.2
2534

2635
## [0.11.1] - 2025-09-23
@@ -380,6 +389,7 @@ and commits should be formatted using [Conventional Commits](https://www.convent
380389

381390

382391

392+
[unreleased]: https://github.com/moodlehq/wiki-rag/compare/v0.11.2..HEAD
383393
[0.11.2]: https://github.com/moodlehq/wiki-rag/compare/v0.11.1..v0.11.2
384394
[0.11.1]: https://github.com/moodlehq/wiki-rag/compare/v0.11.0..v0.11.1
385395
[0.11.0]: https://github.com/moodlehq/wiki-rag/compare/v0.10.0..v0.11.0

wiki_rag/load/util.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,6 @@ def get_mediawiki_parsed_pages(
136136
})
137137
except Exception as e:
138138
logger.error(f' Error processing page "{page["title"]}": {e}')
139-
finally:
140-
continue
141139

142140
# Now that all the pages and their sections are in memory, we can convert any wiki link
143141
# to a "relation" to the target section. That will improve the context organisation later,

wiki_rag/search/util.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,9 @@ def load_prompts_for_rag(prompt_name: str) -> ChatPromptTemplate:
146146
f"Error loading the prompt {prefixed_prompt_name} from {prompt_provider}: {e}. Applying default one."
147147
)
148148
chat_prompt = load_prompts_for_rag_from_local(prompt_name)
149-
finally:
150-
logger.debug(f"Returning the prompt {prompt_name}: {chat_prompt}")
151-
return chat_prompt
149+
150+
logger.debug(f"Returning the prompt {prompt_name}: {chat_prompt}")
151+
return chat_prompt
152152

153153

154154
def convert_prompts_for_rag_from_langfuse(langfuse_prompt: TextPromptClient) -> ChatPromptTemplate:

wiki_rag/server/util.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,5 +211,5 @@ def _check_token_with_service(token: str) -> bool:
211211
status_code = requests.get(auth_url, headers={"Authorization": f"Bearer {token}"}).status_code
212212
except requests.exceptions.ConnectionError as e:
213213
logger.error(f"Error checking token with service {auth_url}: {e}")
214-
finally:
215-
return status_code == 200
214+
215+
return status_code == 200

0 commit comments

Comments
 (0)