refactor: deprecate write_substring

Author: peter-jerry-ye

array/view.mbt

@@ -380,23 +380,19 @@ pub fn[A : @string.ToStringView] ArrayView::join(
       size_hint = size_hint << 1
       let buf = StringBuilder::new(size_hint~)
       // buf.write_string(hd)
-      buf.write_substring(hd.data(), hd.start_offset(), hd.length())
+      buf.write_view(hd)
       if separator is "" {
         for s in tl {
           // buf.write_string(s)
           let s = s.to_string_view()
-          buf.write_substring(s.data(), s.start_offset(), s.length())
+          buf.write_view(s)
         }
       } else {
         for s in tl {
           let s = s.to_string_view()
-          buf.write_substring(
-            separator.data(),
-            separator.start_offset(),
-            separator.length(),
-          )
+          buf.write_view(separator)
           // buf.write_string(s)
-          buf.write_substring(s.data(), s.start_offset(), s.length())
+          buf.write_view(s)
         }
       }
       buf.to_string()

buffer/buffer.mbt

@@ -846,7 +846,7 @@ pub fn Buffer::write_string_utf16be(buf : Self, string : StringView) -> Unit {
 ///
 /// ```moonbit
 ///   let buf = @buffer.new()
-///   buf.write_substring("Hello, World!", 0, 5)
+///   buf.write_view("Hello, World!"[:5])
 ///   inspect(
 ///     buf.contents(),
 ///     content=(
@@ -856,16 +856,15 @@ pub fn Buffer::write_string_utf16be(buf : Self, string : StringView) -> Unit {
 ///     ),
 ///   )
 /// ```
-pub impl Logger for Buffer with write_substring(
-  self : Buffer,
-  value : String,
-  start : Int,
-  len : Int,
-) -> Unit {
-  guard start >= 0 && len >= 0 && start + len <= value.length()
-  self.grow_if_necessary(self.len + len * 2)
-  self.data.blit_from_string(self.len, value, start, len)
-  self.len += len * 2
+pub impl Logger for Buffer with write_view(self : Buffer, value : StringView) -> Unit {
+  self.grow_if_necessary(self.len + value.length() * 2)
+  self.data.blit_from_string(
+    self.len,
+    value.data(),
+    value.start_offset(),
+    value.length(),
+  )
+  self.len += value.length() * 2
 }
 
 ///|

buffer/buffer_test.mbt

@@ -74,7 +74,7 @@ test "grow_if_necessary method" {
 ///|
 test "write_substring method" {
   let buf = @buffer.new(size_hint=10)
-  buf.write_substring("Hello, World!", 7, 5)
+  buf.write_view("Hello, World!"[7:12])
   inspect(buf, content="World")
 }
 

builtin/pkg.generated.mbti

@@ -1094,8 +1094,10 @@ impl Hash for BytesView
 impl Hash for StringView
 
 pub(open) trait Logger {
-  write_string(Self, String) -> Unit
-  write_substring(Self, String, Int, Int) -> Unit
+  write_string(Self, String) -> Unit = _
+  #deprecated
+  write_substring(Self, String, Int, Int) -> Unit = _
+  write_view(Self, StringView) -> Unit = _
   write_char(Self, Char) -> Unit = _
 }
 fn[T : Show] &Logger::write_iter(Self, Iter[T], prefix? : String, suffix? : String, sep? : String, trailing? : Bool) -> Unit

builtin/stringbuilder_buffer.mbt

@@ -91,19 +91,21 @@ pub impl Logger for StringBuilder with write_char(self, ch) {
 ///
 /// ```moonbit
 ///   let sb = StringBuilder::new()
-///   sb.write_substring("Hello, world!", 0, 5)
+///   sb.write_view("Hello, world!"[:5])
 ///   assert_eq(sb.to_string(), "Hello")
 /// ```
-pub impl Logger for StringBuilder with write_substring(
+pub impl Logger for StringBuilder with write_view(
   self : StringBuilder,
-  str : String,
-  start : Int,
-  len : Int,
+  str : StringView,
 ) -> Unit {
-  guard start >= 0 && len >= 0 && start + len <= str.length()
-  self.grow_if_necessary(self.len + len * 2)
-  self.data.blit_from_string(self.len, str, start, len)
-  self.len += len * 2
+  self.grow_if_necessary(self.len + str.length() * 2)
+  self.data.blit_from_string(
+    self.len,
+    str.data(),
+    str.start_offset(),
+    str.length(),
+  )
+  self.len += str.length() * 2
 }
 
 ///|

builtin/stringbuilder_concat.mbt

@@ -63,16 +63,14 @@ pub impl Logger for StringBuilder with write_char(self, ch) {
 ///
 /// ```moonbit
 ///   let sb = StringBuilder::new()
-///   sb.write_substring("Hello, world!", 0, 5)
+///   sb.write_view("Hello, world!"[:5])
 ///   assert_eq(sb.to_string(), "Hello")
 /// ```
-pub impl Logger for StringBuilder with write_substring(
+pub impl Logger for StringBuilder with write_view(
   self : StringBuilder,
-  str : String,
-  start : Int,
-  len : Int,
+  str : StringView,
 ) -> Unit {
-  self.val += str.substring(start~, end=start + len)
+  self.val += str.to_string()
 }
 
 ///|

builtin/stringbuilder_test.mbt

@@ -27,7 +27,7 @@ test "stringbuilder" {
   let buf = StringBuilder::new()
   buf.write_string("hello")
   buf.write_char(' ')
-  buf.write_substring("world", 0, 3)
+  buf.write_view("world"[:3])
   inspect(buf.to_string(), content="hello wor")
 }
 

builtin/traits.mbt

@@ -85,11 +85,29 @@ pub(open) trait Default {
 ///|
 /// Trait for a logger, where debug logs can be written into
 pub(open) trait Logger {
-  write_string(Self, String) -> Unit
-  write_substring(Self, String, Int, Int) -> Unit
+  write_string(Self, String) -> Unit = _
+  #deprecated("use `write_view` instead", skip_current_package=true)
+  write_substring(Self, String, Int, Int) -> Unit = _
+  write_view(Self, StringView) -> Unit = _
   write_char(Self, Char) -> Unit = _
 }
 
+///|
+impl Logger with write_substring(self, value, start, len) {
+  self.write_view(try! value[start:start + len])
+}
+
+///|
+impl Logger with write_string(self, value) {
+  self.write_view(value[:])
+}
+
+///|
+#deprecated("replace `impl write_substring` with `impl write_view`")
+impl Logger with write_view(self, value) {
+  self.write_substring(value.data(), value.start_offset(), value.length())
+}
+
 ///|
 impl Logger with write_char(self, value) {
   self.write_string([value])

coverage/coverage.mbt

@@ -111,14 +111,14 @@ pub fn end() -> Unit {
     let mut start = 0
     for j in 0..<str.length() {
       if str.unsafe_charcode_at(j) == '\n' {
-        line_buf.write_substring(str, start, j)
+        line_buf.write_view(try! str[start:j])
         println(line_buf.to_string())
         line_buf.reset()
         start = j + 1
       }
     }
     if start < str.length() {
-      line_buf.write_substring(str, start, str.length())
+      line_buf.write_view(try! str[start:])
     }
   }
   let trailing_line = line_buf.to_string()

json/lex_string.mbt

@@ -18,11 +18,7 @@ fn ParseContext::lex_string(ctx : ParseContext) -> String raise ParseError {
   let mut start = ctx.offset
   fn flush(end : Int) {
     if start > 0 && end > start {
-      buf.write_substring(
-        ctx.input.data(),
-        ctx.input.start_offset() + start,
-        end - start,
-      )
+      buf.write_view(try! ctx.input[start:end])
     }
   }