Remove unnecessary check from PDFLinkService.goToDestination (PR 17984 follow-up)

Snuffleupagus · Snuffleupagus · commit 150964dd6d44 · 2024-04-29T18:54:09.000+02:00
After the changes in PR 17984 this code can no longer be reached, since the destination is now validated on the worker-thread.
diff --git a/web/pdf_link_service.js b/web/pdf_link_service.js
@@ -171,11 +171,6 @@ class PDFLinkService {
       }
     } else if (Number.isInteger(destRef)) {
       pageNumber = destRef + 1;
-    } else {
-      console.error(
-        `goToDestination: "${destRef}" is not a valid destination reference, for dest="${dest}".`
-      );
-      return;
     }
     if (!pageNumber || pageNumber < 1 || pageNumber > this.pagesCount) {
       console.error(

Original file line number	Diff line number	Diff line change
`@@ -171,11 +171,6 @@ class PDFLinkService {`
`171`	`171`	`}`
`172`	`172`	`} else if (Number.isInteger(destRef)) {`
`173`	`173`	`pageNumber = destRef + 1;`
`174`		`- } else {`
`175`		`- console.error(`
`176`		- `goToDestination: "${destRef}" is not a valid destination reference, for dest="${dest}".`
`177`		`- );`
`178`		`- return;`
`179`	`174`	`}`
`180`	`175`	`if (!pageNumber \|\| pageNumber < 1 \|\| pageNumber > this.pagesCount) {`
`181`	`176`	`console.error(`