-
-
Notifications
You must be signed in to change notification settings - Fork 269
[Zurich] Admin interface for managing hierarchical attributes #5606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5606 +/- ##
==========================================
+ Coverage 82.45% 82.49% +0.04%
==========================================
Files 448 448
Lines 34997 35154 +157
Branches 5665 5704 +39
==========================================
+ Hits 28856 29000 +144
- Misses 4469 4476 +7
- Partials 1672 1678 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dracos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only some small display suggestions :)
dracos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, only spotted this while reviewing the other PR. They said in the quote the name for the 'sub' tables is non unique, which I took to mean that you could have two entries in e.g. Objekt with the same name but in different Geschäftsbereich. I thought I had tested this here, but it doesn't seem to work so perhaps I didn't - the "already exists" check here should only be unique per 'parent' if there's a parent, I guess fixes it? Done in fixup
957ba95 to
ef630f0
Compare
chrismytton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! 👍
Interface allows creation, editing and deletion of attributes associated with a division. These attributes will then be added to the admin report screen, to allow admins to update these attributes before the reports is reassigned to a subdivision. Entries can have the same name if they have different parents. Co-authored-by: Matthew Somerville <[email protected]>
4f73008 to
d18ca52
Compare
Co-authored-by: Matthew Somerville <[email protected]>
Co-authored-by: Matthew Somerville <[email protected]>
d18ca52 to
01d6429
Compare
06ab534 to
3d365a9
Compare
[edit: This PR now also incorporates #5631 and #5635]
Interface allows creation, editing and deletion of attributes associated with a division. These attributes will then be added to the admin report screen to allow admins to update these attributes before the reports is reassigned to a subdivision.
Fixes https://github.com/mysociety/societyworks/issues/4973
Fixes https://github.com/mysociety/societyworks/issues/4974
Fixes https://github.com/mysociety/societyworks/issues/4975
Screenshot