Skip to content

Conversation

@chrismytton
Copy link
Member

@chrismytton chrismytton commented Aug 12, 2025

[edit: This PR now also incorporates #5631 and #5635]

Interface allows creation, editing and deletion of attributes associated with a division. These attributes will then be added to the admin report screen to allow admins to update these attributes before the reports is reassigned to a subdivision.

Fixes https://github.com/mysociety/societyworks/issues/4973
Fixes https://github.com/mysociety/societyworks/issues/4974
Fixes https://github.com/mysociety/societyworks/issues/4975

Screenshot

image

@chrismytton chrismytton requested a review from dracos August 12, 2025 12:31
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 90.56604% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.49%. Comparing base (abd7bd9) to head (01d6429).
⚠️ Report is 272 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/App/Controller/Admin/Bodies.pm 89.90% 6 Missing and 5 partials ⚠️
perllib/FixMyStreet/Cobrand/Zurich.pm 92.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5606      +/-   ##
==========================================
+ Coverage   82.45%   82.49%   +0.04%     
==========================================
  Files         448      448              
  Lines       34997    35154     +157     
  Branches     5665     5704      +39     
==========================================
+ Hits        28856    29000     +144     
- Misses       4469     4476       +7     
- Partials     1672     1678       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only some small display suggestions :)

@chrismytton chrismytton requested a review from dracos August 26, 2025 11:22
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, thanks!

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, only spotted this while reviewing the other PR. They said in the quote the name for the 'sub' tables is non unique, which I took to mean that you could have two entries in e.g. Objekt with the same name but in different Geschäftsbereich. I thought I had tested this here, but it doesn't seem to work so perhaps I didn't - the "already exists" check here should only be unique per 'parent' if there's a parent, I guess fixes it? Done in fixup

@dracos dracos force-pushed the zurich-hierarchical-attributes branch 2 times, most recently from 957ba95 to ef630f0 Compare September 4, 2025 20:01
Copy link
Member Author

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 👍

dracos and others added 2 commits September 5, 2025 12:10
Interface allows creation, editing and deletion of attributes associated
with a division. These attributes will then be added to the admin report
screen, to allow admins to update these attributes before the reports is
reassigned to a subdivision. Entries can have the same name if they have
different parents.

Co-authored-by: Matthew Somerville <[email protected]>
@dracos dracos force-pushed the zurich-hierarchical-attributes branch from 4f73008 to d18ca52 Compare September 5, 2025 11:13
@dracos dracos force-pushed the zurich-hierarchical-attributes branch from d18ca52 to 01d6429 Compare September 5, 2025 12:12
@dracos dracos force-pushed the master branch 2 times, most recently from 06ab534 to 3d365a9 Compare October 10, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants