-
Notifications
You must be signed in to change notification settings - Fork 51.7k
Feat(core) add chat create operation to teams node #20096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat(core) add chat create operation to teams node #20096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| members: members.map((member) => { | ||
| const userBinding = member.userId.includes('@') | ||
| ? `https://graph.microsoft.com/v1.0/users('${member.userId}')` | ||
| : `https://graph.microsoft.com/v1.0/users('${member.userId}')`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Redundant Ternary Check Causes Binding Issues
The userBinding ternary operator's branches are identical, making the userId.includes('@') check redundant. Both branches generate the same URL, which may cause incorrect Microsoft Graph API binding if email addresses and user IDs need different formats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the ternary currently looks redundant, but I kept it on purpose to clearly distinguish the two input cases (userId as email vs. object ID).
According to Microsoft Graph documentation, both identifiers use the same API call format:
For now, both resolve to:
https://graph.microsoft.com/v1.0/users('{user-id-or-upn}')
However, keeping the explicit check makes the code self-documenting and leaves room for potential API differences or future adjustments without refactoring again.
I’d prefer to keep this structure for clarity and maintainability rather than removing it now and possibly re-introducing it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 9 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
|
Hey @emmaanuel, Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request. Before we can proceed, please ensure the following: Regarding new nodes: If your node integrates with an AI service that you own or represent, please email [email protected] and we will be happy to discuss the best approach. About review timelines: Thank you again for contributing to n8n. |
|
hi @Joffcom, |
Summary
This PR adds a new Chat resource with Create operation to the Microsoft Teams node (v2), allowing users to create both one-on-one and group chats directly from n8n workflows.
What's added:
How to test:
API Integration:
POST /v1.0/chatsendpointRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)Technical Implementation Details:
Files Modified/Created:
Test Files:
Test Results: ✅ All tests passing (45/45 test suites)
Build Status: ✅ Clean build with no compilation errors
This implementation follows n8n's established patterns and maintains backward compatibility with existing Microsoft Teams node functionality.## Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)