Skip to content

Commit f07b7f4

Browse files
committed
fix: correct linting errors in green-house-migration project
- Fixed hadolint errors in Dockerfile: * Specified exact Python version (3.12.7-alpine) * Separated ENV statements instead of using backslashes * Added --no-cache-dir to apk add and pip install commands - Fixed stylelint errors in style.css: * Changed #ffffff to #fff for shorter hex color * Changed rgba(0, 0, 0, 0.1) to rgba(0, 0, 0, 10%) for modern color notation * Reordered selectors to fix specificity issues (.sidebar-menu a before .site-title a:hover) - Fixed htmlhint errors in index.html: * Changed DOCTYPE to lowercase * Moved title element to be first in head section
1 parent ce80272 commit f07b7f4

File tree

4 files changed

+27
-27
lines changed

4 files changed

+27
-27
lines changed

examples/green-house-migration/Dockerfile

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# Single stage Dockerfile for Greenhouse API Proxy
2-
FROM python:3.12-alpine
2+
FROM python:3.12.7-alpine
33

44
# Set environment variables
5-
ENV PYTHONDONTWRITEBYTECODE=1 \
6-
PYTHONUNBUFFERED=1 \
7-
PYTHONPATH=/app \
8-
PORT=8000
5+
ENV PYTHONDONTWRITEBYTECODE=1
6+
ENV PYTHONUNBUFFERED=1
7+
ENV PYTHONPATH=/app
8+
ENV PORT=8000
99

1010
# Install system dependencies
11-
RUN apk add --no-cache \
11+
RUN apk add --no-cache-dir \
1212
gcc \
1313
musl-dev \
1414
libffi-dev \
@@ -17,7 +17,7 @@ RUN apk add --no-cache \
1717
git
1818

1919
# Install pipenv
20-
RUN pip install pipenv
20+
RUN pip install --no-cache-dir pipenv
2121

2222
# Create non-root user
2323
RUN addgroup -g 1000 appuser && adduser -D -s /bin/sh -u 1000 -G appuser appuser

examples/green-house-migration/config.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,22 @@
77

88

99
def get_required_env(key: str) -> str:
10-
"""Obtener variable de entorno requerida."""
11-
value = os.getenv(key)
12-
if not value:
13-
raise ValueError(f"Variable de entorno {key} es requerida")
14-
return value
10+
"""Obtener variable de entorno requerida."""
11+
value = os.getenv(key)
12+
if not value:
13+
raise ValueError(f"Variable de entorno {key} es requerida")
14+
return value
1515

1616

1717
def get_optional_env(key: str, default: str = "") -> str:
18-
"""Obtener variable de entorno opcional."""
19-
return os.getenv(key, default)
18+
"""Obtener variable de entorno opcional."""
19+
return os.getenv(key, default)
2020

2121

2222
# Configuración de la API
2323
GREENHOUSE_API_KEY = get_required_env("GREENHOUSE_API_KEY")
2424
GREENHOUSE_API_URL = get_optional_env(
25-
"GREENHOUSE_API_URL", "https://harvest.greenhouse.io/v1"
25+
"GREENHOUSE_API_URL", "https://harvest.greenhouse.io/v1"
2626
)
2727

2828
# Configuración de la aplicación

examples/green-house-migration/dashboard/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
<!DOCTYPE html>
1+
<!doctype html>
22
<html lang="en">
33
<head>
4+
<title>TeamTailor Sourced Candidates Analytics Dashboard</title>
45
<meta charset="UTF-8" />
56
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
6-
<title>TeamTailor Sourced Candidates Analytics Dashboard</title>
77
<link
88
rel="icon"
99
type="image/svg+xml"

examples/green-house-migration/docs/assets/css/style.css

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ body {
1212
Ubuntu, Cantarell, sans-serif;
1313
line-height: 1.6;
1414
color: #24292e;
15-
background-color: #ffffff;
15+
background-color: #fff;
1616
}
1717

1818
/* Header */
@@ -39,6 +39,14 @@ body {
3939
text-decoration: none;
4040
}
4141

42+
.sidebar-menu a {
43+
color: #0366d6;
44+
text-decoration: none;
45+
padding: 0.25rem 0;
46+
display: block;
47+
transition: color 0.2s;
48+
}
49+
4250
.site-title a:hover {
4351
color: #f0f0f0;
4452
}
@@ -68,7 +76,7 @@ body {
6876
background: white;
6977
padding: 2rem;
7078
border-radius: 8px;
71-
box-shadow: 0 2px 8px rgba(0, 0, 0, 0.1);
79+
box-shadow: 0 2px 8px rgba(0, 0, 0, 10%);
7280
}
7381

7482
/* Sidebar */
@@ -100,14 +108,6 @@ body {
100108
margin-bottom: 0.5rem;
101109
}
102110

103-
.sidebar-menu a {
104-
color: #0366d6;
105-
text-decoration: none;
106-
padding: 0.25rem 0;
107-
display: block;
108-
transition: color 0.2s;
109-
}
110-
111111
.sidebar-menu a:hover {
112112
color: #0056b3;
113113
text-decoration: underline;

0 commit comments

Comments
 (0)