Replace lazy_static with std::sync::OnceLock in nats-server #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
requested changes
Sep 4, 2024
Collaborator
There was a problem hiding this comment.
Thanks for opening the pull request!
Previously we've replaced lazy_static with Lazy (e.g 70d34f6).
LazyCell just landed in v1.80, can we use that instead? (https://doc.rust-lang.org/std/cell/struct.LazyCell.html)
That'd apply to all the crates, probably removing both the dependency on once_cell and lazy_static.
cc @Jarema , we okay with bumping minimal to 1.8.x?
Member
|
Honestly I would avoid bumping to the latest release without a good justification, and this does not look like one (however I like the idea of uzing LazyCell). Unless we bump it just for the server wrapper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.