From 64b9650f19bca6c646dfe598b82faa1a9f225d12 Mon Sep 17 00:00:00 2001 From: Michael Barry Date: Wed, 8 Oct 2025 10:27:37 -0500 Subject: [PATCH] Use only common.labels.standard for label generation Use only the common.labels.standard function to manage label creation. Using both the common.labels.standard function and then manually defining labels above creates redundant labels and incorrect formatting. Fixes #419 --- charts/diode/templates/_helpers.tpl | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/charts/diode/templates/_helpers.tpl b/charts/diode/templates/_helpers.tpl index e1237f61..609aa0e1 100644 --- a/charts/diode/templates/_helpers.tpl +++ b/charts/diode/templates/_helpers.tpl @@ -42,15 +42,7 @@ Create chart name and version as used by the chart label. Common labels */}} {{- define "diode.labels" -}} -helm.sh/chart: {{ include "diode.chart" . }} -{{ include "diode.selectorlabels" . }} -{{- if .Chart.AppVersion }} -app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} -{{- end }} -app.kubernetes.io/managed-by: {{ .Release.Service }} -{{- if .Values.global.commonLabels }} -{{- include "common.labels.standard" ( dict "customLabels" .Values.global.commonLabels "context" $ ) }} -{{- end }} +{{- include "common.labels.standard" ( dict "customLabels" .Values.global.commonLabels "context" . ) }} {{- end }} {{/*