Skip to content

Commit 7e30843

Browse files
Merge pull request #41 from netboxlabs/features-2025.11.01
addresses issue where non-existent templates and/or lxcs would cause …
2 parents 31789b7 + 68fe373 commit 7e30843

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

setup/netbox_setup_objects_and_custom_fields.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,14 @@ def get_arguments():
2727

2828

2929
def create_custom_field_choice_sets_proxmox_vm_templates(proxmox_api_obj):
30-
proxmox_api_obj.proxmox_get_vm_templates()
30+
proxmox_vm_templates = proxmox_api_obj.proxmox_get_vm_templates()
3131
extra_choices = []
3232

33-
for k, v in proxmox_api_obj.proxmox_vm_templates.items():
34-
extra_choices.append([str(k), v])
33+
if proxmox_vm_templates:
34+
for k, v in proxmox_vm_templates.items():
35+
extra_choices.append([str(k), v])
36+
else:
37+
extra_choices.append([str(-1), 'proxmox-vm-template-stub'])
3538

3639
ncfcs = NetBoxCustomFieldChoiceSets(netbox_url, netbox_api_token, {'name': 'proxmox-vm-templates', 'extra_choices': extra_choices})
3740
return dict(ncfcs.obj)['id']
@@ -62,10 +65,11 @@ def create_custom_field_choice_sets_proxmox_lxc_templates(proxmox_api_obj):
6265
for psv in proxmox_lxc_templates:
6366
extra_choices.append([psv, proxmox_lxc_templates[psv]])
6467

65-
ncfcs = NetBoxCustomFieldChoiceSets(netbox_url, netbox_api_token, {'name': 'proxmox-lxc-templates', 'extra_choices': extra_choices})
66-
return dict(ncfcs.obj)['id']
67-
68-
return 0
68+
else:
69+
extra_choices.append(['placeholder-lxc-template', 'proxmox-lxc-templates-stub'])
70+
71+
ncfcs = NetBoxCustomFieldChoiceSets(netbox_url, netbox_api_token, {'name': 'proxmox-lxc-templates', 'extra_choices': extra_choices})
72+
return dict(ncfcs.obj)['id']
6973

7074

7175
def create_custom_field_choice_sets_proxmox_vm_cluster_nodes(proxmox_api_obj):

0 commit comments

Comments
 (0)