Merge pull request #279 from netguru/fix/prepush

fix: prepush

Author: mateusz1913

jest/setupTests.js

@@ -1 +1 @@
-jest.mock('react-native/Libraries/Animated/src/NativeAnimatedHelper');
+jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper');

package.json

@@ -33,7 +33,7 @@
     "example": "yarn --cwd example",
     "pods": "echo pods",
     "bootstrap": "yarn example && yarn && yarn pods",
-    "prepush": "yarn test && yarn lint & yarn typescript"
+    "prepush": "yarn lint && yarn typescript && yarn test"
   },
   "dependencies": {
     "prop-types": "^15.7.2"

src/StickyParallaxHeaderComponent.tsx

@@ -439,7 +439,7 @@ class StickyParallaxHeaderComponent extends Component<StickyParallaxHeaderProps,
           bouncesZoom
           decelerationRate={decelerationRate}
           nestedScrollEnabled
-          ref={(c) => {
+          ref={(c: ScrollView | Animated.LegacyRef<ScrollView> | null) => {
             this.scroll = getSafelyScrollNode(c) as ScrollView;
             setRef<ScrollView>(scrollRef, this.scroll);
           }}

src/components/ScrollableTabBar/ScrollableTabBar.tsx

@@ -194,7 +194,7 @@ class ScrollableTabBar extends React.PureComponent<ScrollableTabBarProps, State>
                 accessible
                 style={[tabWrapperStyle, styles.noMargins]}
                 accessibilityLabel={tabKey}
-                accessibilityTraits="button"
+                accessibilityRole="button"
                 activeOpacity={0.9}
                 onPress={() => this.goToPage(page)}>
                 <View

src/components/ScrollableTabView/ScrollableTabView.tsx

@@ -290,8 +290,8 @@ class ScrollableTabView extends React.Component<ScrollableTabViewProps, State> {
         pagingEnabled
         contentContainerStyle={{ minHeight: minScrollHeight }}
         automaticallyAdjustContentInsets={false}
-        contentOffset={{ x: initialPage * containerWidth }}
-        ref={(scrollView) => {
+        contentOffset={{ x: initialPage * containerWidth, y: 0 }}
+        ref={(scrollView: ScrollView | Animated.LegacyRef<ScrollView> | null) => {
           this.scrollView = getSafelyScrollNode(scrollView);
         }}
         onScroll={Animated.event([{ nativeEvent: { contentOffset: { x: scrollXIOS } } }], {

src/predefinedComponents/DetailsHeader/DetailsHeader.tsx

@@ -146,13 +146,13 @@ class DetailsHeader extends React.Component<DetailsHeaderProps, State> {
     const {
       headerLayout: { height },
     } = this.state;
-    const headerBorderRadius =
-      hasBorderRadius &&
-      this.scrollY.y.interpolate({
-        inputRange: [0, height],
-        outputRange: [80, 0],
-        extrapolate: 'extend',
-      });
+    const headerBorderRadius = hasBorderRadius
+      ? this.scrollY.y.interpolate({
+          inputRange: [0, height],
+          outputRange: [80, 0],
+          extrapolate: 'extend',
+        })
+      : 0;
 
     return (
       <Animated.View

src/tests/__snapshots__/AvatarHeader.test.tsx.snap

@@ -151,6 +151,7 @@ exports[`AvatarHeader Test [Hacktoberfest] -Snapshot AvatarHeader 1`] = `
     scrollEventThrottle={1}
     showsVerticalScrollIndicator={false}
     stickyHeaderIndices={Array []}
+    style={Object {}}
   >
     <View>
       <View
@@ -320,6 +321,7 @@ exports[`AvatarHeader Test [Hacktoberfest] -Snapshot AvatarHeader 1`] = `
           contentOffset={
             Object {
               "x": 0,
+              "y": 0,
             }
           }
           directionalLockEnabled={true}
@@ -333,6 +335,7 @@ exports[`AvatarHeader Test [Hacktoberfest] -Snapshot AvatarHeader 1`] = `
           scrollEventThrottle={16}
           scrollsToTop={false}
           showsHorizontalScrollIndicator={false}
+          style={Object {}}
         >
           <View />
         </RCTScrollView>

src/tests/__snapshots__/DetailsHeader.test.tsx.snap

@@ -128,6 +128,7 @@ exports[`DetailsHeader empty Snapshot for default 1`] = `
     scrollEventThrottle={1}
     showsVerticalScrollIndicator={false}
     stickyHeaderIndices={Array []}
+    style={Object {}}
   >
     <View>
       <View
@@ -325,6 +326,7 @@ exports[`DetailsHeader empty Snapshot for default 1`] = `
           contentOffset={
             Object {
               "x": 0,
+              "y": 0,
             }
           }
           directionalLockEnabled={true}
@@ -338,6 +340,7 @@ exports[`DetailsHeader empty Snapshot for default 1`] = `
           scrollEventThrottle={16}
           scrollsToTop={false}
           showsHorizontalScrollIndicator={false}
+          style={Object {}}
         >
           <View />
         </RCTScrollView>

src/tests/__snapshots__/StickyParallaxHeader.test.tsx.snap

@@ -33,6 +33,7 @@ exports[`StickyParallaxHeader empty Snapshot for default 1`] = `
     scrollEventThrottle={1}
     showsVerticalScrollIndicator={false}
     stickyHeaderIndices={Array []}
+    style={Object {}}
   >
     <View>
       <View
@@ -109,6 +110,7 @@ exports[`StickyParallaxHeader empty Snapshot for default 1`] = `
           contentOffset={
             Object {
               "x": 0,
+              "y": 0,
             }
           }
           directionalLockEnabled={true}
@@ -122,6 +124,7 @@ exports[`StickyParallaxHeader empty Snapshot for default 1`] = `
           scrollEventThrottle={16}
           scrollsToTop={false}
           showsHorizontalScrollIndicator={false}
+          style={Object {}}
         >
           <View />
         </RCTScrollView>