Support custom query params in addition to args, filter and attrs (to allow pagination support eg. pageno=1&pagesize=10)

Author: stkomitov

service/config.go

@@ -40,6 +40,7 @@ type FindParams struct {
 	ArgsMap                  map[string]string
 	FilterMap                map[string]string
 	AttrsMap                 map[string]string
+	QueryMap                 map[string]string
 	ResourceType             string
 	ResourceName             string
 	ResourceMissingErrorCode int
@@ -80,6 +81,9 @@ func constructQueryString(findParams *FindParams) string {
 	concatQueryString(&queryBuilder, constructQueryMapString("args=", findParams.ArgsMap))
 	concatQueryString(&queryBuilder, constructQueryMapString("filter=", findParams.FilterMap))
 	concatQueryString(&queryBuilder, constructQueryMapString("attrs=", findParams.AttrsMap))
+	for k, v := range findParams.QueryMap {
+		concatQueryString(&queryBuilder, fmt.Sprintf("%s=%s", k, v))
+	}
 
 	return queryBuilder.String()
 }

service/config_test.go

@@ -929,6 +929,14 @@ func TestConstructQueryString(t *testing.T) {
 
 	expected := "?args=bye:hello,hello:bye&filter=bye:hello,hello:bye&attrs=bye:hello,hello:bye"
 	t.Run("CASE=8", generateTestCase(findParams, expected))
+
+	findParams = FindParams{
+		FilterMap: map[string]string{"bye": "hello"},
+		ArgsMap:   map[string]string{"bye": "hello"},
+		AttrsMap:  map[string]string{"bye": "hello"},
+		QueryMap:  map[string]string{"bye": "hello"}}
+
+	t.Run("CASE=9", generateTestCase(findParams, "?args=bye:hello&filter=bye:hello&attrs=bye:hello&bye=hello"))
 }
 
 func TestConstructUrlPathString(t *testing.T) {