Merge pull request #7738 from nextcloud/fix/improve-translations

SebastianKrupinski · web-flow · commit a273708f12b1 · 2025-12-01T13:34:20.000-05:00
fix: improve translations
diff --git a/lib/Service/Proposal/ProposalService.php b/lib/Service/Proposal/ProposalService.php
@@ -511,7 +511,7 @@ private function sendEmailNotifications(IUser $user, ProposalObject $proposal, P
 		}
 		// duration
 		if ($proposal->getDuration() > 0) {
-			$template->addBodyListItem((string)$proposal->getDuration() . ' minutes', $this->l10n->t('Duration:'));
+			$template->addBodyListItem($this->l10n->t('%1$s minutes', [(string)$proposal->getDuration()]), $this->l10n->t('Duration:'));
 		}
 		// dates
 		$temporaryText = '';
@@ -648,7 +648,7 @@ private function constructCalendarBlocker(IUser $user, ProposalObject $proposal)
 		$vEvent->add('DTSTART', $firstProposalDate);
 		$vEvent->add('DURATION', "PT{$proposal->getDuration()}M");
 		$vEvent->add('RDATE', $proposalDates);
-		$vEvent->add('SUMMARY', $this->l10n->t('[Proposed] ') . $proposal->getTitle());
+		$vEvent->add('SUMMARY', $this->l10n->t('[Proposed] %1$s', [$proposal->getTitle()]));
 		if (!empty($proposal->getDescription())) {
 			$vEvent->add('DESCRIPTION', $proposal->getDescription());
 		}

Original file line number	Diff line number	Diff line change
`@@ -511,7 +511,7 @@ private function sendEmailNotifications(IUser $user, ProposalObject $proposal, P`
`511`	`511`	`}`
`512`	`512`	`// duration`
`513`	`513`	`if ($proposal->getDuration() > 0) {`
`514`		`- $template->addBodyListItem((string)$proposal->getDuration() . ' minutes', $this->l10n->t('Duration:'));`
	`514`	`+ $template->addBodyListItem($this->l10n->t('%1$s minutes', [(string)$proposal->getDuration()]), $this->l10n->t('Duration:'));`
`515`	`515`	`}`
`516`	`516`	`// dates`
`517`	`517`	`$temporaryText = '';`
`@@ -648,7 +648,7 @@ private function constructCalendarBlocker(IUser $user, ProposalObject $proposal)`
`648`	`648`	`$vEvent->add('DTSTART', $firstProposalDate);`
`649`	`649`	`$vEvent->add('DURATION', "PT{$proposal->getDuration()}M");`
`650`	`650`	`$vEvent->add('RDATE', $proposalDates);`
`651`		`- $vEvent->add('SUMMARY', $this->l10n->t('[Proposed] ') . $proposal->getTitle());`
	`651`	`+ $vEvent->add('SUMMARY', $this->l10n->t('[Proposed] %1$s', [$proposal->getTitle()]));`
`652`	`652`	`if (!empty($proposal->getDescription())) {`
`653`	`653`	`$vEvent->add('DESCRIPTION', $proposal->getDescription());`
`654`	`654`	`}`