-
Notifications
You must be signed in to change notification settings - Fork 101
Migrate Webpack to Vite build system #2507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results 12 files 588 suites 2m 21s ⏱️ Results for commit fb66eb0. ♻️ This comment has been updated with latest results. |
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
005143e to
21c30e1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2507 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 95 95
Lines 2762 2762
=======================================
Hits 2170 2170
Misses 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@taye, I just saw, why I knew a bit about the Webpack -> Vite migration 😉 I have completely forgotten about this one. We can start from scratch or rebase/fix this one if we (you) want to go with Vite. |
|
@christianlupus Nice :D. I'll start from here |
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Taye Adeyemi <[email protected]>
Signed-off-by: Taye Adeyemi <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
|
/approve |
nextcloud-cookbook-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approved by GitHub action on behalf of /approve
Signed-off-by: Taye Adeyemi <[email protected]>
Topic and Scope
This will migrate to Vite packer finally
Concerns/issues
This is not finally tested 😉
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.