Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Topic and Scope

This will migrate to Vite packer finally

Concerns/issues

This is not finally tested 😉

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@github-actions
Copy link

github-actions bot commented Sep 18, 2024

Test Results

   12 files    588 suites   2m 21s ⏱️
  581 tests   580 ✅ 1 💤 0 ❌
2 324 runs  2 319 ✅ 5 💤 0 ❌

Results for commit fb66eb0.

♻️ This comment has been updated with latest results.

Christian Wolf added 3 commits September 20, 2024 13:20
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.56%. Comparing base (380a4a8) to head (21c30e1).
⚠️ Report is 599 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2507   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files          95       95           
  Lines        2762     2762           
=======================================
  Hits         2170     2170           
  Misses        592      592           
Flag Coverage Δ
integration 21.14% <ø> (ø)
migration 5.46% <ø> (ø)
unittests 56.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christianlupus
Copy link
Collaborator Author

@taye, I just saw, why I knew a bit about the Webpack -> Vite migration 😉

I have completely forgotten about this one. We can start from scratch or rebase/fix this one if we (you) want to go with Vite.

@taye
Copy link

taye commented Oct 2, 2025

@christianlupus Nice :D. I'll start from here

Christian Wolf and others added 8 commits October 2, 2025 12:13
@christianlupus christianlupus marked this pull request as ready for review October 2, 2025 10:42
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants