Skip to content

Commit 4fe671d

Browse files
authored
Merge pull request #13431 from nextcloud/backport/13430/stable30
[stable30] fix(developer): use correct CSS variable name
2 parents b401f16 + 4ed6455 commit 4fe671d

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ as a part of this some CSS variables were added and other deprecated with Nextcl
3636

3737
Clickable area
3838
^^^^^^^^^^^^^^
39-
The size of the CSS variable ``--clickable-area`` variable has shrunk from ``44px`` to ``34px``.
39+
The size of the CSS variable ``--default-clickable-area`` variable has shrunk from ``44px`` to ``34px``.
4040
This will result in several regressions and paper-cuts in your app that will need to be manually fixed.
4141
It's recommended to:
4242

@@ -47,6 +47,11 @@ It's recommended to:
4747
5) Also report ``@nextlcoud/vue`` library regressions if they're not reported already in their list;
4848
6) Fix regression in your app (only the ones that are unrelated to the ``@nextcloud/vue`` components);
4949

50+
Moreover for different use cases also two new variables were added:
51+
52+
- ``--clickable-area-large`` for main UI elements.
53+
- ``--clickable-area-small`` representing the smallest possible size of interactive elements, used by tertiary actions like filter chips.
54+
5055
Line height
5156
^^^^^^^^^^^
5257
The ``--default-line-height`` variable has changed from ``24px``` to ``1.5`` for the ``--default-font-size`` this

developer_manual/html_css_design/css.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ Element structure variables
182182
+----------------------------------------------+------------------------------------------------+-----------------------------------------------------------------------------------------------------------+
183183
| ``--default-font-size`` | ``15px`` | Font size for normal text |
184184
+----------------------------------------------+------------------------------------------------+-----------------------------------------------------------------------------------------------------------+
185-
| ``--default-line-height`` | ``24px`` | Line height for normal text, for accessibility this should always be ``calc(1.5 * var(--font-size))`` |
185+
| ``--default-line-height`` | ``1.5`` | Line height for normal text |
186186
+----------------------------------------------+------------------------------------------------+-----------------------------------------------------------------------------------------------------------+
187187
| ``--default-grid-baseline`` | ``4px`` | Foundation of all spacing sizes used on Nextcloud which are multiples of the baseline size |
188188
+----------------------------------------------+------------------------------------------------+-----------------------------------------------------------------------------------------------------------+

0 commit comments

Comments
 (0)