Merge pull request #172 from nextcloud/feat/use-server-tasktype

Feat: use server tasktype for changing tone if available

Author: julien-nc

lib/AppInfo/Application.php

@@ -100,7 +100,9 @@ public function register(IRegistrationContext $context): void {
 			$context->registerTaskProcessingProvider(TopicsProvider::class);
 			$context->registerTaskProcessingProvider(ContextWriteProvider::class);
 			$context->registerTaskProcessingProvider(ReformulateProvider::class);
-			$context->registerTaskProcessingTaskType(ChangeToneTaskType::class);
+			if (!class_exists('OCP\\TaskProcessing\\TaskTypes\\TextToTextChangeTone')) {
+				$context->registerTaskProcessingTaskType(ChangeToneTaskType::class);
+			}
 			$context->registerTaskProcessingProvider(ChangeToneProvider::class);
 			if (class_exists('OCP\\TaskProcessing\\TaskTypes\\TextToTextChatWithTools')) {
 				$context->registerTaskProcessingProvider(\OCA\OpenAi\TaskProcessing\TextToTextChatWithToolsProvider::class);

lib/TaskProcessing/ChangeToneProvider.php

@@ -36,6 +36,9 @@ public function getName(): string {
 	}
 
 	public function getTaskTypeId(): string {
+		if (class_exists('OCP\\TaskProcessing\\TaskTypes\\TextToTextChangeTone')) {
+			return \OCP\TaskProcessing\TaskTypes\TextToTextChangeTone::ID;
+		}
 		return ChangeToneTaskType::ID;
 	}
 
@@ -46,7 +49,7 @@ public function getExpectedRuntime(): int {
 	public function getInputShapeEnumValues(): array {
 		$toneInputEnumValue = new ShapeEnumValue($this->l->t('Detect language'), 'detect_language');
 		return [
-			'tone_input' => [
+			'tone' => [
 				new ShapeEnumValue($this->l->t('Friendlier'), 'friendler'),
 				new ShapeEnumValue($this->l->t('More formal'), 'more formal'),
 				new ShapeEnumValue($this->l->t('Funnier'), 'funnier'),
@@ -58,7 +61,7 @@ public function getInputShapeEnumValues(): array {
 
 	public function getInputShapeDefaults(): array {
 		return [
-			'tone_input' => 'friendler',
+			'tone' => 'friendler',
 		];
 	}
 
@@ -112,7 +115,7 @@ public function process(?string $userId, array $input, callable $reportProgress)
 			throw new RuntimeException('Invalid input text');
 		}
 		$textInput = $input['input'];
-		$toneInput = $input['tone_input'];
+		$toneInput = $input['tone'];
 		$prompt = "Reformulate the following text in a $toneInput tone in its original language. Output only the reformulation. Here is the text:" . "\n\n" . $textInput . "\n\n" . 'Do not mention the used language in your reformulation. Here is your reformulation in the same language:';
 
 		$maxTokens = null;

lib/TaskProcessing/ChangeToneTaskType.php

@@ -49,7 +49,7 @@ public function getInputShape(): array {
 				$this->l->t('Write a text that you want the assistant to rewrite in another tone.'),
 				EShapeType::Text,
 			),
-			'tone_input' => new ShapeDescriptor(
+			'tone' => new ShapeDescriptor(
 				$this->l->t('Desired tone'),
 				$this->l->t('In which tone should your text be rewritten?'),
 				EShapeType::Enum,

tests/unit/Providers/OpenAiProviderTest.php

@@ -259,7 +259,7 @@ public function testChangeToneProvider(): void {
 
 		$this->iClient->expects($this->once())->method('post')->with($url, $options)->willReturn($iResponse);
 
-		$result = $changeToneProvider->process(self::TEST_USER1, ['input' => $textInput, 'tone_input' => $toneInput ], fn () => null);
+		$result = $changeToneProvider->process(self::TEST_USER1, ['input' => $textInput, 'tone' => $toneInput ], fn () => null);
 		$this->assertEquals('This is a test response.', $result['output']);
 
 		// Check that token usage is logged properly