Skip to content

Commit d089a3c

Browse files
author
Lionel Elie Mamane
committed
correctly handle case of empty range or UID list
''.split(',') returns [''], not []
1 parent bc50e4f commit d089a3c

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

js/settings.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,11 @@
3535
{
3636
success: function(data) {
3737
var textData = $(data).find('data data').text();
38-
var ipRanges = textData.split(',');
38+
var ipRanges;
39+
if( textData === '')
40+
ipRanges = []
41+
else
42+
ipRanges = textData.split(',');
3943
var table = document.getElementById('limit-login-to-ip-list');
4044
table.innerHTML = '';
4145

@@ -70,7 +74,11 @@
7074
{
7175
success: function(data) {
7276
var textData = $(data).find('data data').text();
73-
var UIDs = textData.split(',');
77+
var UIDs;
78+
if( textData === '')
79+
UIDs = []
80+
else
81+
UIDs = textData.split(',');
7482
var table = document.getElementById('limit-login-to-ip-uidlist');
7583
table.innerHTML = '';
7684

0 commit comments

Comments
 (0)