perf(s3): Provide direct pre-signed download link

This is faster than going back to nextcloud to download the files.

Signed-off-by: Carl Schwan <[email protected]>

Author: Carl Schwan

lib/private/Files/ObjectStore/Azure.php

@@ -117,4 +117,8 @@ public function objectExists($urn) {
 	public function copyObject($from, $to) {
 		$this->getBlobClient()->copyBlob($this->containerName, $to, $this->containerName, $from);
 	}
+
+	public function preSignedUrl(string $urn, \DateTimeInterface $expiration): ?string {
+		return null;
+	}
 }

lib/private/Files/ObjectStore/ObjectStoreStorage.php

@@ -812,4 +812,16 @@ public function cancelChunkedWrite(string $targetPath, string $writeToken): void
 	public function setPreserveCacheOnDelete(bool $preserve) {
 		$this->preserveCacheItemsOnDelete = $preserve;
 	}
+
+	public function getDirectDownload(string $path): array|false {
+		$path = $this->normalizePath($path);
+		$cacheEntry = $this->getCache()->get($path);
+
+		if (!$cacheEntry || $cacheEntry->getMimeType() === FileInfo::MIMETYPE_FOLDER) {
+			return [];
+		}
+
+		$url = $this->objectStore->preSignedUrl($this->getURN($cacheEntry->getId()), new \DateTime('+60 minutes'));
+		return $url ? ['url' => $url] : [];
+	}
 }

lib/private/Files/ObjectStore/S3ObjectTrait.php

@@ -7,6 +7,7 @@
 namespace OC\Files\ObjectStore;
 
 use Aws\Command;
+use Aws\Exception\AwsException;
 use Aws\Exception\MultipartUploadException;
 use Aws\S3\Exception\S3MultipartUploadException;
 use Aws\S3\MultipartCopy;
@@ -279,4 +280,18 @@ public function copyObject($from, $to, array $options = []) {
 			], $options));
 		}
 	}
+
+	public function preSignedUrl(string $urn, \DateTimeInterface $expiration): ?string {
+		$command = $this->getConnection()->getCommand('GetObject', [
+			'Bucket' => $this->getBucket(),
+			'Key' => $urn,
+		]);
+
+		try {
+			return $this->getConnection()->createPresignedRequest($command, $expiration)->getUri();
+		} catch (AwsException $exception) {
+			$this->logger->warning("Unable to create pre-signed url: " . $exception->getMessage());
+			return null;
+		}
+	}
 }

lib/private/Files/ObjectStore/StorageObjectStore.php

@@ -74,4 +74,8 @@ public function objectExists($urn) {
 	public function copyObject($from, $to) {
 		$this->storage->copy($from, $to);
 	}
+
+	public function getDirectDownload(string $path): array|false {
+		return [];
+	}
 }

lib/private/Files/Storage/Common.php

@@ -446,7 +446,7 @@ public function instanceOfStorage(string $class): bool {
 	}
 
 	/**
-	 * A custom storage implementation can return an url for direct download of a give file.
+	 * A custom storage implementation can return a url for direct download of a give file.
 	 *
 	 * For now the returned array can hold the parameter url - in future more attributes might follow.
 	 */

lib/public/Files/ObjectStore/IObjectStore.php

@@ -63,4 +63,10 @@ public function objectExists($urn);
 	 * @since 21.0.0
 	 */
 	public function copyObject($from, $to);
+
+	/**
+	 * Get pre signed url for an object
+	 * @since 32.0.0
+	 */
+	public function preSignedUrl(string $urn, \DateTimeInterface $expiration): ?string;
 }