Skip to content

[stable31] fix(chat): improve mixed bidi content render #16059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: stable31
Choose a base branch
from
Draft

[stable31] fix(chat): improve mixed bidi content render #16059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,9 +535,30 @@ export default {
}

:deep(.rich-text--wrapper) {
text-align: start;
// NcRichText is used with dir="auto", so internal text direction may vary
// But we want to keep the alignment consistent with the rest of the UI
text-align: inherit;

@include markdown;
}

// FIXME: Should it be in the upstream NcRichText component?
// NcRichText is used with dir="auto", so internal text direction may vary
// But we want to keep the alignment consistent with the rest of the UI
// So we need to override the direction for task lists using the current direction, not its own direction
&:dir(rtl) :deep(ul.contains-task-list) {
direction: rtl;
}

&:dir(ltr) :deep(ul.contains-task-list) {
direction: ltr;
}

// Overriding direction above breaks text direction
// Restoring it back
:deep(ul.contains-task-list) .checkbox-content__wrapper {
unicode-bidi: plaintext;
}
}
}

Expand Down