-
Notifications
You must be signed in to change notification settings - Fork 499
fix(CalendarEventsDialog): Style upcoming meetings as tertiary #16146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: kramo <[email protected]>
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally fine with the change, it fits better with top bar styles in general. But aren't we losing some highlighting/accent with it (read as importance of seeing the meeting information)?
Co-authored-by: Maksim Sukharev <[email protected]> Signed-off-by: kramo <[email protected]>
Don't think so. If a call is ongoing, it is highlighted. I don't think we need to highlight a meeting potentially a week in the future. |
|
I agree for meetings in a week, but for meetings that are timely-close (lets say ~1h like event rooms or maybe even more until 4h?) I could see it. My problem with tertiary is that it basically makes it invisible for new users that they can schedule meetings there? |
Makes sense, maybe it could be highlighted with a badge or little dot or something then. But in any case, that would be a different feature since currently, the color does not represent "close in time".
To be honest, I never thought of doing that before even with the current style haha. It's probably more of an information architectural issue rather than one of style. We already use tertiary to communicate that you can get more info from state/status-like buttons, including in the same header with the conversation name/description. |
I mean, the name of the conversation acts as a button as well and has the same styling. I certainly have opinions about using buttons with no background in general, but we definitely do for this case at the moment and that is a much broader topic. I am interested in exploring the tertiary style in toolbars and such but yes, broader issue :) |

This fixes the low padding and generally weird style for a status button that was there previously.
ποΈ UI Checklist
πΌοΈ Screenshots / Screencasts
π Checklist
(PS: This is just a quick one-liner so I did not actually test it as I don't have a dev env set up for Talk, please tell me if something doesn't work haha)