Skip to content

Conversation

@kra-mo
Copy link
Member

@kra-mo kra-mo commented Oct 16, 2025

This fixes the low padding and generally weird style for a status button that was there previously.

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

🏚️ Before 🏑 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

(PS: This is just a quick one-liner so I did not actually test it as I don't have a dev env set up for Talk, please tell me if something doesn't work haha)

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally fine with the change, it fits better with top bar styles in general. But aren't we losing some highlighting/accent with it (read as importance of seeing the meeting information)?

Co-authored-by: Maksim Sukharev <[email protected]>
Signed-off-by: kramo <[email protected]>
@kra-mo
Copy link
Member Author

kra-mo commented Oct 16, 2025

I personally fine with the change, it fits better with top bar styles in general. But aren't we losing some highlighting/accent with it (read as importance of seeing the meeting information)?

Don't think so. If a call is ongoing, it is highlighted. I don't think we need to highlight a meeting potentially a week in the future.

@nickvergessen
Copy link
Member

I agree for meetings in a week, but for meetings that are timely-close (lets say ~1h like event rooms or maybe even more until 4h?) I could see it.

My problem with tertiary is that it basically makes it invisible for new users that they can schedule meetings there?

@DorraJaouad
Copy link
Contributor

maybe it still needs a border? it looks like floating with no anchor

image

@kra-mo
Copy link
Member Author

kra-mo commented Oct 16, 2025

for meetings that are timely-close (lets say ~1h like event rooms or maybe even more until 4h?) I could see it.

Makes sense, maybe it could be highlighted with a badge or little dot or something then. But in any case, that would be a different feature since currently, the color does not represent "close in time".

My problem with tertiary is that it basically makes it invisible for new users that they can schedule meetings there?

To be honest, I never thought of doing that before even with the current style haha. It's probably more of an information architectural issue rather than one of style. We already use tertiary to communicate that you can get more info from state/status-like buttons, including in the same header with the conversation name/description.

@kra-mo
Copy link
Member Author

kra-mo commented Oct 16, 2025

maybe it still needs a border? it looks like floating with no anchor

I mean, the name of the conversation acts as a button as well and has the same styling.

I certainly have opinions about using buttons with no background in general, but we definitely do for this case at the moment and that is a much broader topic.

I am interested in exploring the tertiary style in toolbars and such but yes, broader issue :)

@kra-mo
Copy link
Member Author

kra-mo commented Oct 16, 2025

cc @nimishavijay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants