Skip to content

Commit b2f5c12

Browse files
committed
FIX issues API
Signed-off-by: Nicolas Lamirault <[email protected]>
1 parent 3a3a8da commit b2f5c12

File tree

6 files changed

+21
-10
lines changed

6 files changed

+21
-10
lines changed

ChangeLog.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
11
# emacs-gitlab ChangeLog
22

3-
## Version 0.3 (IN PROGRESS)
3+
## Version 0.4 (05/29/2015)
44

5-
- ``#8``: Invalid URL for issue project
5+
- Initial support for Users API (Thanks [marcinant][])
6+
- ``FIX`` unit tests on Issues API
7+
- Support Notes API (Thanks [marcinant][])
8+
- Support Milestone API (Thanks [marcinant][])
9+
10+
## Version 0.3 (04/19/2015)
11+
12+
- ``#8``: Invalid URL for issue project
613
- Refactoring unit tests (use [ert-runner][] and [overseer][])
714
- ``#7``: Fixed multiline descriptions breaking tabulated view (Thanks [marcinant][])
815
- ``#4``: FIX Documentation (Thanks [marcinant][])

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ elpa:
5858
.PHONY: build
5959
build : elpa $(OBJECTS)
6060

61-
test: build
61+
test: clean build
6262
@echo -e "$(OK_COLOR)[$(APP)] Unit tests$(NO_COLOR)"
6363
@$(CASK) exec ert-runner
6464

gitlab-issues.el

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,14 @@ LABELS - Comma-separated list of label names"
4343

4444

4545
(defun gitlab--get-issue-uri (project-id issue-id)
46+
"Retrieve URI to retrieve an issue.
47+
PROJECT-ID : The ID of a project
48+
ISSUE-ID : The ID of a project issue"
4649
(s-concat "projects/"
4750
(url-hexify-string
4851
(format "%s" project-id))
4952
"/issues/"
50-
(number-to-string issue-id)))
53+
issue-id))
5154

5255
(defun gitlab-list-project-issues (project-id)
5356
"Get a list of project issues.
@@ -70,7 +73,7 @@ ISSUE-ID : The ID of a project issue"
7073
(gitlab--get-issue-uri
7174
(url-hexify-string
7275
(format "%s" project-id))
73-
issue-id)
76+
(format "%s" issue-id))
7477
nil
7578
200))
7679

gitlab-utils.el

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
;;; gitlab-utils.el --- some tools
22

3-
;; Copyright (C) 2014 Nicolas Lamirault <[email protected]>
3+
;; Copyright (C) 2014, 2015 Nicolas Lamirault <[email protected]>
44

55
;; This program is free software; you can redistribute it and/or
66
;; modify it under the terms of the GNU General Public License

gitlab.el

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
;; Author: Nicolas Lamirault <[email protected]>
44
;; URL: https://github.com/nlamirault/emacs-gitlab
5-
;; Version: 0.3.0
5+
;; Version: 0.4.0
66
;; Keywords: gitlab
77

88
;; Package-Requires: ((s "1.9.0") (dash "2.9.0") (pkg-info "0.5.0") (request "0.1.0"))
99

10-
;; Copyright (C) 2014 Nicolas Lamirault <[email protected]>
10+
;; Copyright (C) 2014, 2015 Nicolas Lamirault <[email protected]>
1111

1212
;; This program is free software; you can redistribute it and/or
1313
;; modify it under the terms of the GNU General Public License

test/gitlab-issues-test.el

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,11 @@
5656
issues)))))
5757

5858
(ert-deftest test-get-single-issue ()
59-
:tags '(issues)
59+
:tags '(issues current)
6060
(with-test-sandbox
6161
(with-gitlab-session
62-
(let ((issue (gitlab-get-issue gitlab-project-id "85657"))) ;gitlab-issue-id)))
62+
(let ((issue (gitlab-get-issue gitlab-project-id gitlab-issue-id)))
63+
(message "Issue : %s" issue)
6364
(should (s-equals? gitlab-issue-title
6465
(assoc-default 'title issue)))))))
6566

0 commit comments

Comments
 (0)