Upgraded to nock 14 and tests are throwing timeout errors

[malwarebo]

Please avoid duplicates

• I checked all open bugs and none of them matched my problem.

Reproducible test case

NA

Nock Version

14.0.4

Node Version

v22.11.0

TypeScript Version

5.8.3

What happened?

I am trying to upgrade from nock 13.5.0 to nock 14.0.4 and I am seeing test failures with timeout errors.
I traced back to different versions and it starts happening after @mswjs/interceptors was introduced in v14.0.0-beta.14

Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

The test suite runs Mocha and Chai.

Would you be interested in contributing a fix?

• yes

[lithin]

We're experiencing the same issue on upgrade from 13.5.6 to 14.0.0. Interceptors intermittently don't match up, with error:
message: request to https://example.com/video/e3d329a8-b99d-43ea-b769-0b84570ccc63 failed, reason: Nock: Disallowed net connect for "example.com:443/video/e3d329a8-b99d-43ea-b769-0b84570ccc63". This can lead to timeouts on tests if there are long retries on these requests, or the tests are flakey.

[mikicho]

Thanks for the report!.
Can you please share minimum reproducible example? (no ts, no react, not 3rd packages as possible)

[lithin]

This issue seems to be happening over a fair variety of uses so the basic reproducible issue would boil down to this.

Test:

describe('recommendations', () => {
  beforeEach(() => {
    nock.disableNetConnect();
  });
  
  afterEach(() => {
    nock.cleanAll();
    nock.enableNetConnect();
  });

  it('returns the correct amount of unique recommendations', async () => {
    const someUUID = uuid();
    const repeatedId = uuid();
    const idGroup = [uuid(), uuid(), uuid()];

    nock('https://example.com', {
      encodedQueryParams: true,
    })
      .get(`/${someUUID}`)
      .reply(200, { idGroup });

    const result = await getVideoRecommendations(someUUID);
    expect(result.length).toEqual(3);
  });
});

Code:

export const getVideoRecommendations = async (contentId) => {
    const response = await fetch(`https://example.com/${contentId}`);

    if (response.ok) {
      const data = await response.json();

      return data.idGroup;    
    }
};

We can only really reliably reproduce this when running our entire test suite of hundreds of tests. If we isolate a single test or test file, this issue doesn't seem to happen.

[alemarcha]

Hello. Any update about this? I have the same issue after upgrade to 14.0.4

[malwarebo]

@mikicho were you able to reproduce this?

[mikicho]

@lithin I run this example 1000 times (with mocha) and it worked for me:

import { randomUUID } from "node:crypto";
import nock from "nock";
import { expect } from 'chai'

for (let i = 0; i < 1000; i++) {
  
  describe('recommendations', () => {
    beforeEach(() => {
      nock.disableNetConnect();
    });
    
    afterEach(() => {
      nock.cleanAll();
      nock.enableNetConnect();
    });

    it('returns the correct amount of unique recommendations', async () => {
      const someUUID = randomUUID();
      const repeatedId = randomUUID();
      const idGroup = [randomUUID(), randomUUID(), randomUUID()];

      nock('https://example.com', {
        encodedQueryParams: true,
      })
        .get(`/${someUUID}`)
        .reply(200, { idGroup });

      const result = await getVideoRecommendations(someUUID);
      expect(result.length).equal(3);
    });
  });
}
export const getVideoRecommendations = async (contentId) => {
    const response = await fetch(`https://example.com/${contentId}`);

    if (response.ok) {
      const data = await response.json();

      return data.idGroup;    
    }
};

Can you please share more details? or a better reproduction.

[lithin]

I've been trying to find repro steps locally but to no avail. Our codebase has over a thousand tests but if I try to narrow it down to a single test file, I never manage to reproduce this in a stable manner. Some more details for our specific use case:

• We run tests in band, in CI we split them into four different containers but run them serially on local
• Repeating a single test, or even a single test file, hundreds of times doesn't reproduce this issue
• Running a smaller subset of tests (eg a specific folder with ~10 test files, all of them using nock) sometimes results in a failure and sometimes not, even if we use the same seed for these runs
• Tests time out and sometimes run out of memory - could this be some kind of a garbage collection issue?

[aclarembeau]

Same issue here: as soon as we run multiple files together, the test breaks :/

[mikicho]

@lithin, for the small subset (point 3), maybe you can ask GPT/Copilot to make a minimal reproduction from these tests? (like remove any proprietary-related code and such)?

[Arshavin86]

Same thing. I had to roll back to ^13 to unblock my tests.

[jNullj]

We seem to have the same issue at shields.io tests when trying to upgrade to v14
https://github.com/badges/shields/actions/runs/17008826497?pr=11289
can be seen in PR badges/shields#11289

I can replicate this by running npm run test:core in our project (before and after changing nock version).

We seem to get the timeout error in a got call, we don't seem to use nock on that test, but somehow this still effects us, maybe from prev test, as at nock v13 we don't get the exception at that line.

See for example here we fail on line 49.