Skip to content

Commit 3ee185d

Browse files
authored
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
The builtins conditions for riscv64 and loong64 both have the form 'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant. This was copied from the mips64/mips64el pattern (where the 'or' is correct since those are two different architectures) when riscv64 and loong64 support were first added. Simplify both to match the pattern used by ppc64, s390x, and other single-variant architectures. Signed-off-by: Jamie Magee <jamie.magee@gmail.com> PR-URL: #62608 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
1 parent cac1a9f commit 3ee185d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tools/v8_gypfiles/v8.gyp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,12 +342,12 @@
342342
'<(V8_ROOT)/src/builtins/arm64/builtins-arm64.cc',
343343
],
344344
}],
345-
['v8_target_arch=="riscv64" or v8_target_arch=="riscv64"', {
345+
['v8_target_arch=="riscv64"', {
346346
'sources': [
347347
'<(V8_ROOT)/src/builtins/riscv/builtins-riscv.cc',
348348
],
349349
}],
350-
['v8_target_arch=="loong64" or v8_target_arch=="loong64"', {
350+
['v8_target_arch=="loong64"', {
351351
'sources': [
352352
'<(V8_ROOT)/src/builtins/loong64/builtins-loong64.cc',
353353
],

0 commit comments

Comments
 (0)