sqlite: remove unnecessary trycatch

araujogui · araujogui · commit 9ed6fae76554 · 2026-07-04T12:58:31.000-03:00
Signed-off-by: Guilherme Araújo &lt;arauujogui@gmail.com&gt;
diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc
@@ -2609,11 +2609,9 @@ void StatementSync::Close(const FunctionCallbackInfo<Value>& args) {
 }
 
 void StatementSync::Dispose(const FunctionCallbackInfo<Value>& args) {
-  v8::TryCatch try_catch(args.GetIsolate());
-  Close(args);
-  if (try_catch.HasCaught()) {
-    CHECK(try_catch.CanContinue());
-  }
+  StatementSync* stmt;
+  ASSIGN_OR_RETURN_UNWRAP(&stmt, args.This());
+  stmt->Close();
 }
 
 inline int StatementSync::ResetStatement() {

Original file line number	Diff line number	Diff line change
`@@ -2609,11 +2609,9 @@ void StatementSync::Close(const FunctionCallbackInfo<Value>& args) {`
`2609`	`2609`	`}`
`2610`	`2610`
`2611`	`2611`	`void StatementSync::Dispose(const FunctionCallbackInfo<Value>& args) {`
`2612`		`- v8::TryCatch try_catch(args.GetIsolate());`
`2613`		`- Close(args);`
`2614`		`- if (try_catch.HasCaught()) {`
`2615`		`- CHECK(try_catch.CanContinue());`
`2616`		`- }`
	`2612`	`+ StatementSync* stmt;`
	`2613`	`+ ASSIGN_OR_RETURN_UNWRAP(&stmt, args.This());`
	`2614`	`+ stmt->Close();`
`2617`	`2615`	`}`
`2618`	`2616`
`2619`	`2617`	`inline int StatementSync::ResetStatement() {`