Fix conflict with IAM role name for additional apps

novekm · novekm · commit feca7a4bd6ed · 2023-05-15T15:16:33.000-04:00
diff --git a/iam.tf b/iam.tf
@@ -17,7 +17,7 @@ data "aws_iam_policy_document" "amplify_trust_relationship" {
 resource "aws_iam_role" "amplify_codecommit" {
   # count               = var.create_codecommit_repo ? 1 : 0
   count               = var.create_codecommit_repo ? 1 : 0
-  name                = var.amplify_codecommit_role_name
+  name                = "${var.amplify_codecommit_role_name}-${var.app_name}"
   assume_role_policy  = data.aws_iam_policy_document.amplify_trust_relationship.json
   managed_policy_arns = ["arn:aws:iam::aws:policy/AWSCodeCommitReadOnly"]
 }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ data "aws_iam_policy_document" "amplify_trust_relationship" {`
`17`	`17`	`resource "aws_iam_role" "amplify_codecommit" {`
`18`	`18`	`# count = var.create_codecommit_repo ? 1 : 0`
`19`	`19`	`count = var.create_codecommit_repo ? 1 : 0`
`20`		`- name = var.amplify_codecommit_role_name`
	`20`	`+ name = "${var.amplify_codecommit_role_name}-${var.app_name}"`
`21`	`21`	`assume_role_policy = data.aws_iam_policy_document.amplify_trust_relationship.json`
`22`	`22`	`managed_policy_arns = ["arn:aws:iam::aws:policy/AWSCodeCommitReadOnly"]`
`23`	`23`	`}`