`Parse()` returns only digest for references that contain both tag and digest. Is this expected?

[davidxia]

I noticed that Parse() returns only the image digest for references that contain both tag and digest instead of both. Is this expected?

import (
	"fmt"
	parser "github.com/novln/docker-parser"
)

func main() {
	imageString := "kuberay/operator:v0.6.0@sha256:cc8ce713f3b4be3c72cca1f63ee78e3733bc7283472ecae367b47a128f7e4478"
	ref, err := parser.Parse(imageString)
	if err != nil {
		panic(err)
	}

	fmt.Printf("Tag: %s\n", ref.Tag())
}

Output

Tag: sha256:cc8ce713f3b4be3c72cca1f63ee78e3733bc7283472ecae367b47a128f7e4478

I expected

Tag: v0.6.0@sha256:cc8ce713f3b4be3c72cca1f63ee78e3733bc7283472ecae367b47a128f7e4478

Would be great if this library supported a way to get both tag and digest if both are in the reference.

[novln]

Sure, feel free to submit a pull request. I'll gladly review it.

P.S.: If you could also link to the documentation/literature where this parsing should be supported, that would be great.

[davidxia]

P.S.: If you could also link to the documentation/literature where this parsing should be supported, that would be great.

I can't find an official spec stating image:tag@digest references must be supported by various container tooling. I did, however, see this in the moby/moby 20.10.20 release notes and containers/common#1248.

Updated handling of image:tag@digest references.

Sure, feel free to submit a pull request. I'll gladly review it.

I'm afraid I don't have the familiarity or bandwidth to contribute here. I found containers/container-libs#225 so hopefully this issue is addressed upstream. 🤞