fix: filter Sonar config "sources" list to only include directories that exist

Author: mdeanjones

packages/ember-cli-sonarqube/lib/report-metrics.js

@@ -10,10 +10,15 @@ const logProgress = require('./utils/log-progress');
 function getSonarConfiguration(config) {
   const pkgJson = JSON.parse(fs.readFileSync(path.join(config.projectRoot, 'package.json'), 'utf8'));
 
-  const sources = (Array.isArray(pkgJson.keywords) && pkgJson.keywords.includes('ember-addon'))
+  let sources = (Array.isArray(pkgJson.keywords) && pkgJson.keywords.includes('ember-addon'))
     ? 'addon,addon-test-support,public'
     : 'app,public';
 
+  sources = sources
+    .split(',')
+    .filter((src) => fs.existsSync(path.join(config.projectRoot, src)))
+    .join(',');
+
   const executionReport = fs.existsSync(config.reporterOut) ? config.reporterOut : undefined;
 
   const eslintReports = [config.codeLintOut, config.tmplLintOut]
@@ -83,3 +88,5 @@ module.exports = function reportSonarMetrics(config) {
     sonarqubeScanner(sonarConfig, resolve);
   });
 }
+
+module.exports.getSonarConfiguration = getSonarConfiguration;

test-packages/__tests__/get-sonar-configuration-test.js

@@ -0,0 +1,20 @@
+const { getConfiguration } = require('@nsf-open/ember-cli-sonarqube/lib/configuration');
+const { getSonarConfiguration } = require('@nsf-open/ember-cli-sonarqube/lib/report-metrics');
+const { getTestPackage } = require('./test-helpers');
+
+
+describe('getSonarConfiguration', function () {
+  const testPackage = getTestPackage('my-addon');
+
+  afterEach(function () {
+    jest.resetModules();
+    return testPackage.reset();
+  });
+
+  it('filters the sources list to only directories that exist', function () {
+    const cliConfig   = getConfiguration(testPackage.toPath(), { 'dry-run': true });
+    const sonarConfig = getSonarConfiguration(cliConfig);
+
+    expect(sonarConfig.options['sonar.sources']).toEqual('addon');
+  });
+});