-
-
Notifications
You must be signed in to change notification settings - Fork 113
Fix: renormalize index line endings to LF/revert .gitattributes
#409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andrej730
wants to merge
2
commits into
nutti:main
Choose a base branch
from
Andrej730:renormalize-lineendings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| * text eol=lf | ||
| * text=auto | ||
| *.sh text eol=lf | ||
2 changes: 1 addition & 1 deletion
2
...y_module_test/analyzer_test_data/base_analyzer_test/input/only_module_class.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| .. module:: module_1 | ||
| .. module:: module_1 |
126 changes: 63 additions & 63 deletions
126
..._module_test/generator_test_data/code_document_node_translator_test/expect/basic/basic.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,63 +1,63 @@ | ||
| """ | ||
| Paragraph: *Emphasis* | ||
| * Bullet List Item 1 | ||
| * Bullet List Item 1-1 | ||
| * Bullet List Item 1-2 | ||
| * Bullet List Item 2 | ||
| * Bullet List Item 2-1 | ||
| * Bullet List Item 2-2 | ||
| * Bullet List Item 2-3 | ||
| * Bullet List Item 3 | ||
| * Bullet List Item 3-1 | ||
| 1. Enumerated List Item 1 | ||
| 1. Enumerated List Item 1-1 | ||
| 2. Enumerated List Item 1-2 | ||
| 2. Enumerated List Item 2 | ||
| 1. Enumerated List Item 2-1 | ||
| 2. Enumerated List Item 2-2 | ||
| 3. Enumerated List Item 2-3 | ||
| 3. Enumerated List Item 3 | ||
| 1. Enumerated List Item 3-1 | ||
| field-list-item-1: Field List Item 1 Contents | ||
| field-list-item-2: Field List Item 2 Contents | ||
| Definition List Item 1 | ||
| Definition List Item 1 Contents | ||
| Definition List Item 2 | ||
| Definition List Item 2 Contents | ||
| ``` | ||
| Literal Block Contents | ||
| ``` | ||
| Module: module_ref, Ref: ref_ref, Class: class_ref | ||
| Function: function_ref, Data: data_ref, Const: const_ref | ||
| [NOTE] | ||
| Note Contents | ||
| [IMPORTANT] | ||
| Important Contents | ||
| [WARNING] | ||
| Warning Contents | ||
| Line Block Contents 1 | ||
| Line Block Contents 2 | ||
| [QUOTE] | ||
| Quote Block Contents 1 | ||
| Quote Block Contents 2 | ||
| Target | ||
| """ | ||
| import typing | ||
| import collections.abc | ||
| import typing_extensions | ||
| import numpy.typing as npt | ||
| """ | ||
| Paragraph: *Emphasis* | ||
|
|
||
| * Bullet List Item 1 | ||
| * Bullet List Item 1-1 | ||
| * Bullet List Item 1-2 | ||
| * Bullet List Item 2 | ||
| * Bullet List Item 2-1 | ||
| * Bullet List Item 2-2 | ||
| * Bullet List Item 2-3 | ||
| * Bullet List Item 3 | ||
| * Bullet List Item 3-1 | ||
|
|
||
| 1. Enumerated List Item 1 | ||
| 1. Enumerated List Item 1-1 | ||
| 2. Enumerated List Item 1-2 | ||
| 2. Enumerated List Item 2 | ||
| 1. Enumerated List Item 2-1 | ||
| 2. Enumerated List Item 2-2 | ||
| 3. Enumerated List Item 2-3 | ||
| 3. Enumerated List Item 3 | ||
| 1. Enumerated List Item 3-1 | ||
|
|
||
| field-list-item-1: Field List Item 1 Contents | ||
| field-list-item-2: Field List Item 2 Contents | ||
|
|
||
| Definition List Item 1 | ||
| Definition List Item 1 Contents | ||
|
|
||
| Definition List Item 2 | ||
| Definition List Item 2 Contents | ||
|
|
||
| ``` | ||
| Literal Block Contents | ||
| ``` | ||
|
|
||
| Module: module_ref, Ref: ref_ref, Class: class_ref | ||
| Function: function_ref, Data: data_ref, Const: const_ref | ||
|
|
||
| [NOTE] | ||
| Note Contents | ||
|
|
||
| [IMPORTANT] | ||
| Important Contents | ||
|
|
||
| [WARNING] | ||
| Warning Contents | ||
|
|
||
| Line Block Contents 1 | ||
| Line Block Contents 2 | ||
|
|
||
| [QUOTE] | ||
| Quote Block Contents 1 | ||
| Quote Block Contents 2 | ||
|
|
||
| Target | ||
|
|
||
| """ | ||
|
|
||
| import typing | ||
| import collections.abc | ||
| import typing_extensions | ||
| import numpy.typing as npt |
68 changes: 34 additions & 34 deletions
68
..._test/transformer_test_data/bpy_module_tweaker/expect/add_bpy_ops_override_parameters.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,34 @@ | ||
| <document source="<string>"> | ||
| <source-filename> | ||
| add_bpy_ops_override_parameters.rst | ||
| <module> | ||
| <name> | ||
| bpy.ops.pose | ||
| <description> | ||
| <function function_type="function"> | ||
| <name> | ||
| function_1 | ||
| <description> | ||
| function_1 description | ||
| <argument-list> | ||
| <argument argument_type="arg"> | ||
| <name> | ||
| arg_1 | ||
| <description> | ||
| function_1 arg_1 description | ||
| <default-value> | ||
| <data-type-list> | ||
| <data-type> | ||
| function_1 arg_1 type | ||
| <return> | ||
| <description> | ||
| <data-type-list> | ||
| <function function_type="function"> | ||
| <name> | ||
| function_2 | ||
| <description> | ||
| function_2 description | ||
| <argument-list> | ||
| <return> | ||
| <description> | ||
| <data-type-list> | ||
| <document source="<string>"> | ||
| <source-filename> | ||
| add_bpy_ops_override_parameters.rst | ||
| <module> | ||
| <name> | ||
| bpy.ops.pose | ||
| <description> | ||
| <function function_type="function"> | ||
| <name> | ||
| function_1 | ||
| <description> | ||
| function_1 description | ||
| <argument-list> | ||
| <argument argument_type="arg"> | ||
| <name> | ||
| arg_1 | ||
| <description> | ||
| function_1 arg_1 description | ||
| <default-value> | ||
| <data-type-list> | ||
| <data-type> | ||
| function_1 arg_1 type | ||
| <return> | ||
| <description> | ||
| <data-type-list> | ||
| <function function_type="function"> | ||
| <name> | ||
| function_2 | ||
| <description> | ||
| function_2 description | ||
| <argument-list> | ||
| <return> | ||
| <description> | ||
| <data-type-list> |
140 changes: 70 additions & 70 deletions
140
...ormer_test_data/bpy_module_tweaker/expect/add_bpy_ops_override_parameters_transformed.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,70 +1,70 @@ | ||
| <document source="<string>"> | ||
| <source-filename> | ||
| add_bpy_ops_override_parameters.rst | ||
| <module> | ||
| <name> | ||
| bpy.ops.pose | ||
| <description> | ||
| <function function_type="function"> | ||
| <name> | ||
| function_1 | ||
| <description> | ||
| function_1 description | ||
| <argument-list> | ||
| <argument argument_type="posonlyarg"> | ||
| <name> | ||
| execution_context | ||
| <description> | ||
| <default-value> | ||
| None | ||
| <data-type-list> | ||
| <data-type> | ||
| str, int | ||
| <argument argument_type="posonlyarg"> | ||
| <name> | ||
| undo | ||
| <description> | ||
| <default-value> | ||
| None | ||
| <data-type-list> | ||
| <data-type> | ||
| bool | ||
| <argument argument_type="kwonlyarg"> | ||
| <name> | ||
| arg_1 | ||
| <description> | ||
| function_1 arg_1 description | ||
| <default-value> | ||
| <data-type-list> | ||
| <data-type> | ||
| function_1 arg_1 type | ||
| <return> | ||
| <description> | ||
| <data-type-list> | ||
| <function function_type="function"> | ||
| <name> | ||
| function_2 | ||
| <description> | ||
| function_2 description | ||
| <argument-list> | ||
| <argument argument_type="posonlyarg"> | ||
| <name> | ||
| execution_context | ||
| <description> | ||
| <default-value> | ||
| None | ||
| <data-type-list> | ||
| <data-type> | ||
| str, int | ||
| <argument argument_type="posonlyarg"> | ||
| <name> | ||
| undo | ||
| <description> | ||
| <default-value> | ||
| None | ||
| <data-type-list> | ||
| <data-type> | ||
| bool | ||
| <return> | ||
| <description> | ||
| <data-type-list> | ||
| <document source="<string>"> | ||
| <source-filename> | ||
| add_bpy_ops_override_parameters.rst | ||
| <module> | ||
| <name> | ||
| bpy.ops.pose | ||
| <description> | ||
| <function function_type="function"> | ||
| <name> | ||
| function_1 | ||
| <description> | ||
| function_1 description | ||
| <argument-list> | ||
| <argument argument_type="posonlyarg"> | ||
| <name> | ||
| execution_context | ||
| <description> | ||
| <default-value> | ||
| None | ||
| <data-type-list> | ||
| <data-type> | ||
| str, int | ||
| <argument argument_type="posonlyarg"> | ||
| <name> | ||
| undo | ||
| <description> | ||
| <default-value> | ||
| None | ||
| <data-type-list> | ||
| <data-type> | ||
| bool | ||
| <argument argument_type="kwonlyarg"> | ||
| <name> | ||
| arg_1 | ||
| <description> | ||
| function_1 arg_1 description | ||
| <default-value> | ||
| <data-type-list> | ||
| <data-type> | ||
| function_1 arg_1 type | ||
| <return> | ||
| <description> | ||
| <data-type-list> | ||
| <function function_type="function"> | ||
| <name> | ||
| function_2 | ||
| <description> | ||
| function_2 description | ||
| <argument-list> | ||
| <argument argument_type="posonlyarg"> | ||
| <name> | ||
| execution_context | ||
| <description> | ||
| <default-value> | ||
| None | ||
| <data-type-list> | ||
| <data-type> | ||
| str, int | ||
| <argument argument_type="posonlyarg"> | ||
| <name> | ||
| undo | ||
| <description> | ||
| <default-value> | ||
| None | ||
| <data-type-list> | ||
| <data-type> | ||
| bool | ||
| <return> | ||
| <description> | ||
| <data-type-list> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you apply this on
.shfile only?We should apply
lfto all files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we apply
lfto all files, then it creates issues on Windows - since Windows is usingcrlf, some Windows programs will keep saving files ascrlfproducing git warnings when working with the repo. And git itself hasautocrlfon Windows enabled by default - so it's checking outlffiles ascrlfto avoid the issues above and applyinglfto everything is conflicting with this.When we do
* text=autofiles are still will be stored on the repo aslf- so if you're on Unix, you'll never seecrlffiles. It's just thatautowill check out them on Windows ascrlfto avoid issues above. Though we still need to applylfto.shscripts, otherwise there will be issues executing them on Windows.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, will all files be stored on the git repository as
lf?