-
Notifications
You must be signed in to change notification settings - Fork 388
add 'statusBarMode' to drive whether the status bar is hidden or not. #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
4d9ab3a
701db3f
8a0aae7
57d6cb1
6f9f981
35f5f9d
d133894
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,12 @@ extern NSString * const NYTPhotosViewControllerDidDismissNotification; | |
|
|
||
| @interface NYTPhotosViewController : UIViewController | ||
|
|
||
| typedef NS_ENUM(NSUInteger, NYTPhotoViewerStatusBarMode) { | ||
| NYTPhotoViewerStatusBarModeDynamic, /* hide statusbar when view.safeArea.top == 0 */ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A doc comment instead of a regular comment would make this show up in the inline doc viewer. Probably best to add comments for all the cases. |
||
| NYTPhotoViewerStatusBarModeHidden, | ||
| NYTPhotoViewerStatusBarModeShown | ||
| }; | ||
|
|
||
| /** | ||
| * The pan gesture recognizer used for panning to dismiss the photo. Disable to stop the pan-to-dismiss behavior. | ||
| */ | ||
|
|
@@ -75,6 +81,12 @@ extern NSString * const NYTPhotosViewControllerDidDismissNotification; | |
| */ | ||
| @property (nonatomic, readonly, nullable) NYTPhotosOverlayView *overlayView; | ||
|
|
||
| /** | ||
| * This determines whether we display the status bar or not | ||
| * Defaults to NYTPhotoViewerStatusBarModeDynamic. | ||
| */ | ||
| @property (nonatomic) NYTPhotoViewerStatusBarMode statusBarMode; | ||
|
|
||
| /** | ||
| * The left bar button item overlaying the photo. | ||
| */ | ||
|
|
@@ -177,6 +189,20 @@ extern NSString * const NYTPhotosViewControllerDidDismissNotification; | |
|
|
||
| @optional | ||
|
|
||
| /** | ||
| * Called when the view is about to made visible. | ||
| * | ||
| * @param photosViewController The `NYTPhotosViewController` instance that sent the delegate message. | ||
| */ | ||
| - (void)photosViewController:(NYTPhotosViewController *)photosViewController viewWillAppear:(BOOL)animated; | ||
|
|
||
| /** | ||
| * Called when the view is dismissed, covered or otherwise hidden. | ||
| * | ||
| * @param photosViewController The `NYTPhotosViewController` instance that sent the delegate message. | ||
| */ | ||
| - (void)photosViewController:(NYTPhotosViewController *)photosViewController viewWillDisappear:(BOOL)animated; | ||
|
|
||
| /** | ||
| * Called when a new photo is displayed through a swipe gesture. | ||
| * | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,8 @@ fi | |
|
|
||
| cd "$(dirname "$0")/../Examples" | ||
|
|
||
| bundle config set path 'vendor/bundle' | ||
| # uncomment the following if you get errors about not having access to the system's install | ||
mr-fixit marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # bundle config --local path 'vendor/bundle' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's actually pretty rare to mention this stuff in a script like this. If we want to guide people on their ruby setup, maybe we should do it in the readme instead, under a "Contributing" section?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i'm happy to delete it. it's probably wrong-advice anyway. |
||
|
|
||
| bundle install | ||
| bundle exec pod install | ||
Uh oh!
There was an error while loading. Please reload this page.