[IMP] runbot: add required fields to OAuth providers

Author: Xavier-Do

runbot/__manifest__.py

@@ -8,7 +8,7 @@
     'category': 'Website',
     'version': '5.14',
     'application': True,
-    'depends': ['base', 'base_automation', 'website'],
+    'depends': ['base', 'base_automation', 'website', 'auth_oauth'],
     'data': [
         'security/runbot_security.xml',
         'security/ir.model.access.csv',
@@ -53,6 +53,7 @@
         'views/dashboard_views.xml',
         'views/dockerfile_views.xml',
         'views/host_views.xml',
+        'views/oauth_provider_views.xml',
         'views/repo_views.xml',
         'views/res_config_settings_views.xml',
         'views/stat_views.xml',

runbot/models/__init__.py

@@ -19,6 +19,7 @@
 from . import ir_model_fields_converter
 from . import ir_qweb
 from . import ir_logging
+from . import oauth_provider
 from . import project
 from . import repo
 from . import res_config_settings

runbot/models/oauth_provider.py

@@ -0,0 +1,11 @@
+from odoo import models, fields
+
+
+class OAuthProvider(models.Model):
+    _inherit = 'auth.oauth.provider'
+
+    required_fields = fields.Char(
+        string="Required Fields",
+        help="List of fields that are required to sign up a user using this OAuth provider. "
+             "Fields should be separated by spaces.",
+    )

runbot/models/res_users.py

@@ -2,6 +2,7 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
 from odoo import fields, models
+from odoo.exceptions import ValidationError
 
 
 class ResUsers(models.Model):
@@ -23,3 +24,18 @@ def write(self, values):
         if list(values.keys()) == ['github_login'] and self.env.user.has_group('runbot.group_runbot_team_manager'):
             return super(ResUsers, self.sudo()).write(values)
         return super().write(values)
+
+    def _auth_oauth_validate(self, provider, access_token):
+        validation = super()._auth_oauth_validate(provider, access_token)
+        provider = self.env['auth.oauth.provider'].browse(provider)
+        required_fields = (provider.required_fields or '').split()
+        for field in required_fields:
+            if not validation.get(field):
+                raise ValidationError("The `%s` field is required to sign in." % field)
+        return validation
+
+    def _generate_signup_values(self, provider, validation, params):
+        signup_values = super()._generate_signup_values(provider, validation, params)
+        if 'github_login' in validation:
+            signup_values['github_login'] = validation['github_login']
+        return signup_values

runbot/views/oauth_provider_views.xml

@@ -0,0 +1,14 @@
+<odoo>
+<data>
+    <record id="view_oauth_provider_form" model="ir.ui.view">
+        <field name="name">auth.oauth.provider.form</field>
+        <field name="model">auth.oauth.provider</field>
+        <field name="inherit_id" ref="auth_oauth.view_oauth_provider_form" />
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='scope']" position="after">
+                <field name="required_fields"/>
+            </xpath>
+        </field>
+    </record>
+</data>
+</odoo>