🚨 Linting

Author: pboling

.rubocop_gradual.lock

@@ -1,5 +1,5 @@
 {
-  "README.md:2478083419": [
+  "README.md:4226975945": [
     [277, 3, 100, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 3592044714]
   ],
   "bin/bundle:247448467": [
@@ -31,12 +31,17 @@
     [57, 13, 125, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 3604044426],
     [69, 13, 83, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 902334745]
   ],
-  "lib/omniauth/identity/models/rom.rb:1077115502": [
-    [23, 9, 814, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 2641680277],
-    [34, 33, 14, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 3392992668],
-    [56, 13, 15, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 1768297560],
-    [72, 18, 20, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 2230320645],
-    [73, 54, 20, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 2230320645]
+  "lib/omniauth/identity/models/rom.rb:1006067066": [
+    [28, 9, 866, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 3432708653],
+    [39, 33, 14, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 3392992668],
+    [60, 13, 14, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 2710654061],
+    [61, 25, 14, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 2710654061],
+    [66, 13, 18, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 3343971124],
+    [67, 13, 18, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 3343971124],
+    [71, 13, 20, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 2230320645],
+    [72, 13, 20, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 2230320645],
+    [76, 13, 15, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 3094507655],
+    [77, 14, 15, "ThreadSafety/ClassInstanceVariable: Avoid class instance variables.", 3094507655]
   ],
   "lib/omniauth/identity/models/sequel.rb:101522047": [
     [44, 9, 3379, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 3595458005]
@@ -102,7 +107,7 @@
     [14, 1, 61, "RSpec/SpecFilePathFormat: Spec path should end with `omni_auth/identity/models/mongoid*_spec.rb`.", 2184534986],
     [32, 9, 71, "RSpec/SubjectStub: Do not stub methods of the object under test.", 399334056]
   ],
-  "spec_orms/rom_spec.rb:1364234352": [
+  "spec_orms/rom_spec.rb:2272636079": [
     [5, 1, 57, "RSpec/SpecFilePathFormat: Spec path should end with `omni_auth/identity/models/rom*_spec.rb`.", 18469108],
     [6, 3, 12, "RSpec/BeforeAfterAll: Beware of using `before(:all)` as it may cause state to leak between tests. If you are using `rspec-rails`, and `use_transactional_fixtures` is enabled, then records created in `before(:all)` are not automatically rolled back.", 86334566]
   ],

lib/omniauth/identity/models/rom.rb

@@ -92,11 +92,11 @@ def locate(conditions)
             else
               conditions
             end
-            return nil if key_value.nil?
+            return if key_value.nil?
 
             relation = rom_container.relations[rom_relation_name]
             identity_data = relation.where(auth_key_symbol => key_value).one
-            return nil unless identity_data
+            return unless identity_data
 
             if owner_relation_name && identity_data[:owner_id]
               owner_data = rom_container.relations[owner_relation_name].where(id: identity_data[:owner_id]).one

spec_orms/rom_spec.rb

@@ -45,7 +45,7 @@
       it "finds a record by custom auth key (login) when auth_key is set to :login" do
         # Temporarily switch the auth key to :login using the public Model.auth_key API
         original = model_klass.auth_key
-        model_klass.auth_key :login
+        model_klass.auth_key(:login)
 
         begin
           # Insert test data using the login field
@@ -57,7 +57,7 @@
           expect(located.login).to(eq("bob"))
         ensure
           # Restore original auth_key to avoid leaking state between tests
-          model_klass.auth_key original
+          model_klass.auth_key(original)
         end
       end
 
@@ -81,7 +81,7 @@
 
       it "authenticates with custom auth_key (login) when auth_key is set to :login" do
         original = model_klass.auth_key
-        model_klass.auth_key :login
+        model_klass.auth_key(:login)
 
         begin
           # Insert test data using login field
@@ -93,7 +93,7 @@
           expect(authenticated).to(be_a(RomTestIdentity))
           expect(authenticated.login).to(eq("bob"))
         ensure
-          model_klass.auth_key original
+          model_klass.auth_key(original)
         end
       end
 
@@ -116,7 +116,7 @@
     describe "owner_relation_name" do
       it "loads associated owner data when owner_relation_name is configured" do
         # Set up owner_relation_name
-        model_klass.owner_relation_name :rom_test_owners
+        model_klass.owner_relation_name(:rom_test_owners)
 
         # Insert owner data
         owner_data = {name: "John Doe"}