feat: refactor to argocd-agent addon with GitOpsCluster CRD (#109)

BREAKING CHANGE: Complete redesign from basic pull to argocd-agent model

- Add GitOpsCluster CRD for declarative agent management
- Implement OCM addon deployment (internal/addon, internal/controller)
- Remove old controllers/application (basic pull model)
- Rename chart to argocd-agent-addon
- Move main.go to cmd/ directory
- Add automated certificate, RBAC, and server discovery
- Enable managed and autonomous deployment modes

Basic pull model now in OCM repository. See README for migration.

Signed-off-by: Mike Ng <[email protected]>

Author: mikeshng

.dockerignore

@@ -1,4 +1,15 @@
 # More info: https://docs.docker.com/engine/reference/builder/#dockerignore-file
-# Ignore build and test binaries.
-bin/
-testbin/
+# Ignore everything by default and re-include only needed files
+**
+
+# Re-include Go source files (but not *_test.go)
+!**/*.go
+**/*_test.go
+
+# Re-include Go module files
+!go.mod
+!go.sum
+
+# Re-include charts directory for addon embedding
+!charts/
+!internal/addon/charts/

.github/workflows/chart-upload.yml

@@ -8,7 +8,7 @@ on:
     types: [published]
 
 env:
-  CHART_NAME: argocd-pull-integration
+  CHART_NAME: argocd-agent-addon
 
 jobs:
   env:

.github/workflows/e2e.yml

@@ -0,0 +1,79 @@
+name: E2E
+
+on:
+  workflow_dispatch: {}
+  pull_request:
+    branches:
+      - main
+
+env:
+  # Common versions
+  GO_VERSION: '1.24'
+  GO_REQUIRED_MIN_VERSION: ''
+  GOPATH: '/home/runner/work/argocd-pull-integration/argocd-pull-integration/go'
+
+defaults:
+  run:
+    working-directory: go/src/open-cluster-management.io/argocd-pull-integration
+
+jobs:
+  e2e:
+    name: e2e
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+          path: go/src/open-cluster-management.io/argocd-pull-integration
+
+      - name: install Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: ${{ env.GO_VERSION }}
+
+      - name: Add GOPATH/bin to PATH
+        run: echo "$GOPATH/bin" >> "$GITHUB_PATH"
+
+      - name: install imagebuilder
+        run: go install github.com/openshift/imagebuilder/cmd/[email protected]
+
+      # Install Helm so make test-e2e can run helm commands
+      - name: Set up Helm
+        uses: azure/setup-helm@v4
+        with:
+          version: v3.15.2  # pin for reproducibility; omit to get latest v3
+
+      # Optional: pin kubectl to match your kind/k8s version
+      - name: Set up kubectl
+        uses: azure/setup-kubectl@v4
+        with:
+          version: v1.29.0
+
+      - name: build-images
+        run: make build-images
+
+      - name: setup kind (cluster1)
+        uses: engineerd/[email protected]
+        with:
+          version: v0.14.0
+          name: cluster1
+
+      - name: setup kind (hub)
+        uses: engineerd/[email protected]
+        with:
+          version: v0.14.0
+          name: hub
+
+      - name: Load image on the nodes of the hub
+        run: |
+          kind load docker-image --name=hub quay.io/open-cluster-management/argocd-pull-integration:latest
+
+      - name: Load image on the nodes of the cluster1
+        run: |
+          kind load docker-image --name=cluster1 quay.io/open-cluster-management/argocd-pull-integration:latest
+
+      - name: Run e2e test
+        env:
+          KUBECONFIG: /home/runner/.kube/config
+        run: make test-e2e

.github/workflows/go-postsubmit.yml

@@ -24,18 +24,18 @@ jobs:
         arch: [ amd64 ]
     steps:
       - name: checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
           path: go/src/open-cluster-management.io/argocd-pull-integration
       - name: install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
       - name: install imagebuilder
         run: go install github.com/openshift/imagebuilder/cmd/[email protected]
       - name: pull base image
-        run: docker pull registry.access.redhat.com/ubi8/ubi-minimal:latest --platform=linux/${{ matrix.arch }}
+        run: docker pull registry.access.redhat.com/ubi9/ubi-minimal:latest --platform=linux/${{ matrix.arch }}
       - name: images
         run: make docker-build
       - name: push

.github/workflows/go-presubmit.yml

@@ -21,12 +21,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
           path: go/src/open-cluster-management.io/argocd-pull-integration
       - name: install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
       - name: build
@@ -39,31 +39,31 @@ jobs:
         arch: [ amd64 ]
     steps:
       - name: checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
           path: go/src/open-cluster-management.io/argocd-pull-integration
       - name: install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
       - name: install imagebuilder
         run: go install github.com/openshift/imagebuilder/cmd/[email protected]
       - name: pull base image
-        run: docker pull registry.access.redhat.com/ubi8/ubi-minimal:latest --platform=linux/${{ matrix.arch }}
+        run: docker pull registry.access.redhat.com/ubi9/ubi-minimal:latest --platform=linux/${{ matrix.arch }}
       - name: images
         run: make docker-build
   test:
     name: test
     runs-on: ubuntu-latest
     steps:
       - name: checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
           path: go/src/open-cluster-management.io/argocd-pull-integration
       - name: install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
       - name: test

.github/workflows/go-release.yml

@@ -9,7 +9,7 @@ env:
   GO_VERSION: '1.24'
   GO_REQUIRED_MIN_VERSION: ''
   GITHUB_REF: ${{ github.ref }}
-  CHART_NAME: argocd-pull-integration
+  CHART_NAME: argocd-agent-addon
 
 jobs:
   env:

.gitignore

@@ -1,26 +1,27 @@
-
 # Binaries for programs and plugins
 *.exe
 *.exe~
 *.dll
 *.so
 *.dylib
-bin
-testbin/*
+bin/*
 Dockerfile.cross
 
-# Test binary, build with `go test -c`
+# Test binary, built with `go test -c`
 *.test
 
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out
 
-# Kubernetes Generated files - skip generated files, except for vendored files
+# Go workspace file
+go.work
 
+# Kubernetes Generated files - skip generated files, except for vendored files
 !vendor/**/zz_generated.*
 
 # editor and IDE paraphernalia
 .idea
+.vscode
 *.swp
 *.swo
 *~

Dockerfile

@@ -11,16 +11,15 @@ COPY go.sum go.sum
 # and so that source changes don't invalidate our downloaded layer
 RUN go mod download
 
-# Copy the go source
-COPY main.go main.go
-COPY controllers/ controllers/
+# Copy the Go source (relies on .dockerignore to filter)
+COPY . .
 
 # Build
-# the GOARCH has not a default value to allow the binary be built according to the host where the command
+# the GOARCH has no default value to allow the binary to be built according to the host where the command
 # was called. For example, if we call make docker-build in a local env which has the Apple Silicon M1 SO
 # the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore,
 # by leaving it empty we can ensure that the container and binary shipped on it will have the same platform.
-RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -a -o manager main.go
+RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -a -o manager cmd/main.go
 
 # Use distroless as minimal base image to package the manager binary
 # Refer to https://github.com/GoogleContainerTools/distroless for more details