builtins: product, sort, sum #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: implementing internal.member_3 for compliance testing Resolves open-policy-agent#12 Signed-off-by: Dmitry Frenkel <[email protected]>
srenatus
approved these changes
Oct 29, 2025
Contributor
srenatus
left a comment
srenatus
left a comment
There was a problem hiding this comment.
Still new to Swift, but it looks OK. Nicely done with the reduce. And you're extending the test assertions to cover the "want" part, too, when types don't match. 👍
One question inline. 👇
| return try doPlus(args: args) | ||
| } | ||
|
|
||
| static func doPlus(args: [AST.RegoValue]) throws -> AST.RegoValue { |
Contributor
There was a problem hiding this comment.
[swift newbie] Why do we do this? The only difference I spot besides the arguments is that plus is async, doPlus is not.
Contributor
There was a problem hiding this comment.
Exactly - we wanted a (shared) synchronous implementation that could be used in synchronous contexts, but you still need the async signature for the builtin entrypoint because we're plumbed for future async builtins that do I/O.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: implementing internal.member_3 for compliance testing
Resolves #12