[chore] Generate MSI config files to reduce duplication (#1227)

* [chore] generate MSI config files to reduce duplication

* use different delimiters to generate template from template

* write to file, remove old files

* remove old files

* remove file printing

Author: mowies

Makefile

@@ -30,9 +30,12 @@ generate: generate-sources generate-goreleaser
 generate-goreleaser: go
 	@./scripts/generate-goreleaser.sh -d "${DISTRIBUTIONS}" -b "${BINARIES}" -g ${GO}
 
-generate-sources: go ocb
+generate-sources: go ocb generate-msi
 	@./scripts/build.sh -d "${DISTRIBUTIONS}" -s true -b ${OTELCOL_BUILDER}
 
+generate-msi: go ocb
+	$(GO) run cmd/msi-generator/main.go -d "${DISTRIBUTIONS}"
+
 goreleaser-verify: goreleaser
 	@${GORELEASER} release --snapshot --clean
 

cmd/msi-generator/main.go

@@ -0,0 +1,77 @@
+// Copyright The OpenTelemetry Authors
+// SPDX-License-Identifier: Apache-2.0
+
+package main
+
+import (
+	"bytes"
+	"flag"
+	"fmt"
+	"log"
+	"os"
+	"strings"
+	"text/template"
+)
+
+const (
+	coreDistro       = "otelcol"
+	contribDistro    = "otelcol-contrib"
+	otlpDistro       = "otelcol-otlp"
+	templateFilename = "cmd/msi-generator/windows-installer.wxs.tmpl"
+	finalFilename    = "windows-installer.wxs"
+	distroFolder     = "distributions"
+)
+
+var (
+	distFlag = flag.String("d", "", "Collector distributions to build")
+)
+
+func main() {
+	flag.Parse()
+
+	if len(*distFlag) == 0 {
+		log.Fatal("no distribution to template")
+	}
+	distros := strings.Split(*distFlag, ",")
+
+	for _, distro := range distros {
+		log.Println("Templating MSI installer for distribution: " + distro)
+		TemplateDist(distro)
+	}
+}
+
+func TemplateDist(dist string) {
+	switch dist {
+	case coreDistro, contribDistro:
+		templateDist(dist, true)
+	case otlpDistro:
+		templateDist(dist, false)
+	default:
+		log.Println("Unknown distribution: " + dist)
+	}
+}
+
+func templateDist(dist string, addConfig bool) {
+	// Parse the base template
+	baseTemplate, err := template.New("base").Delims("<<", ">>").ParseFiles(templateFilename)
+	if err != nil {
+		panic(err)
+	}
+
+	// Data for the base template
+	data := map[string]interface{}{
+		"AddConfig": addConfig,
+	}
+
+	// Execute the base template to generate a new template
+	var generatedTemplateContent bytes.Buffer
+	err = baseTemplate.ExecuteTemplate(&generatedTemplateContent, "base", data)
+	if err != nil {
+		panic(err)
+	}
+
+	err = os.WriteFile(fmt.Sprintf("%s/%s/%s", distroFolder, dist, finalFilename), generatedTemplateContent.Bytes(), 0644)
+	if err != nil {
+		panic(err)
+	}
+}

distributions/otelcol-contrib/windows-installer.wxs renamed to cmd/msi-generator/windows-installer.wxs.tmpl

@@ -1,3 +1,4 @@
+<< define "base" ->>
 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
    <Product
       Name="OpenTelemetry Collector ({{ .Version }}) - {{ .Binary }} distribution"
@@ -47,10 +48,12 @@
                      Name="{{ .Binary }}.exe"
                      Source="{{ .Binary }}.exe"
                      KeyPath="yes"/>
+                  << if .AddConfig >>
                   <File
                      Id="config.yaml"
                      Name="config.yaml"
                      Source="config.yaml"/>
+                  << end ->>
 
                   <ServiceInstall
                      Id="Sevice"
@@ -86,3 +89,4 @@
       </Directory>
    </Product>
 </Wix>
+<< end >>