-
Notifications
You must be signed in to change notification settings - Fork 215
[chore] enable windows container builds on CI #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
1e28b26 to
6c33a45
Compare
This was referenced Oct 27, 2025
mowies
commented
Oct 27, 2025
mowies
commented
Oct 27, 2025
douglascamata
approved these changes
Oct 28, 2025
add core arm64 update package tests to new package naming scheme update snapshot version config remove arch from k8s since its not needed Revert "refactoring" This reverts commit 590644c. change variable back add prev version to correct step add needs copy over prev tag job refactoring dont run docker tests on windows arm minor changes replace shorthand with longer version try again with windows 2022 runner build local windows image for 2025 try mounting folder on windows try double forward slashes Revert "try again" This reverts commit ccb23f0 remove double backslashes try with redirection after log file name try again fix log file name try backticks try with PS try again on bash for windows try more things revert prep changes again try output redirection again revert cmd option newline revert some variable prep changes fix logging try with newline try shorthand and again try again with PS try running separate docker run cmd for windows more default shells Revert "more default shells" This reverts commit 55ba0ae. set bash as default shell see if explicitely splitting args works one step closer fix more quotes add missing quote remove dash set tag env var correctly use runner_temp dir to be OS independent fix docker cmd set windows dockerfile try building on windows without actions and buildx enable buildx also on windows build container images for testing try to go back to single version without specific OS add back os conditional run variable output on bash more debugging try without quotes debugging try again without backslashes combine linux and windows var prep try to set variables separately for windows also run echo step set variables also on windows try running docker tests on windows runner try to fix version numbers for msi installers fix job name try fixing otelcol core wxs version templating try again to just build MSIs just run docker tests on linux runners simplify variable prep step try running more steps on windows enable windows builds on other distros disable qemu on windows docker-tests job disable msi builds on snapshot builds remove wixl on windows remove unneeded conditional revert removal of wixl Revert "revert changes to windows runner" This reverts commit 6ce5fa6. Revert "disable windows container building skips" This reverts commit cf2f10d. Revert "remove windows skips from goreleaser cfg" This reverts commit b6f4918. Revert "only build windows containers" This reverts commit 69c606c. only build windows containers remove windows skips from goreleaser cfg disable windows container building skips revert changes to windows runner more skipping remove wixl step
songy23
approved these changes
Oct 29, 2025
Member
songy23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mowies !
Merged
via the queue into
open-telemetry:main
with commit Oct 30, 2025
ad76050
107 of 108 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1153
Depends on: